[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling



Il 28/01/2013 20:57, Jakub Wilk ha scritto:
> Do you think upstream could be persuaded to write a test suite?

I think so.

> The manpages could use some improvements:

To improve the manpages I improved the command line help messages (1008_improve_command_line_help.patch)
and implemented a script recreate_manpages.sh that can be manually used to generate manpages.

> - There shouldn't be a colon or an empty line between option names and their descriptions.

Removed.

> - There doesn't seem to be any indication if an option takes an argument or not.

Added.

> - What does "(1)" and "(3)" mean?

Default values, made explicit.

> - Descriptions of some options (e.g. -s in estimate-ngram(1)) are indented differently than the rest.

Fixed.

> - Section numbers for manpages in the SEE ALSO section are missing.

Added.

I also updated:
1002_enable_autotools_build_system.patch
and
1007_escape_filename.patch
The latter fixes .bz2 handling and should work on Windows as well (although I have not tested it yet on a real Windows system).

All the changes currently in the debian patches have been applied upstream.

Bests,
	Giulio.


Reply to: