Re: RFS: etoken-pro-support

[Andreas Barth <aba@not.so.argh.org>]

* Andreas Barth (aba@not.so.argh.org) [070613 11:27]:
> Otherwise, it looks much better than the initial version - I'll give you
> some more comments this evening (or otherwise soon).

Some more in-detail comments now:
- mkproxy seems to be a bit too generic name for me - how about
  etoken-mkproxy?
- why does the source package contain both mkproxy.1 and mkproxy.1.in?
- why does restart in etokend not delete /var/tmp/.etokend (but stop
  does)? (same comment for etsrvd)
- please remove the commands in dh_* you don't need.
- I don't see the reason why you use automake (or even have any makefile
  at all). You could probably install everything with just using
  dh_install (at least debian-specific packages usually could).

Please don't take my comments too bad - the first package is always the
hardest :), and the package now looks to be in good shape for me (and is
considerable better then the earlier version).

Thanks for your work so far.


Cheers,
Andi
-- 
  http://home.arcor.de/andreas-barth/