[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1005049: marked as done (lintian: incorrect leading comma in "sub oxford_enumeration")

Your message dated Sun, 06 Feb 2022 08:21:43 -0800
with message-id <2a8d1dc5-08f0-4aa4-8a2c-bccb444a86c3@www.fastmail.com>
and subject line Re: Bug#1005049: lintian: incorrect leading comma in "sub oxford_enumeration"
has caused the Debian Bug report #1005049,
regarding lintian: incorrect leading comma in "sub oxford_enumeration"
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1005049: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1005049
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: lintian
Version: 2.114.0
Severity: minor

Hi,

I see output like this:

N:   Please refer to , Debian Developer's Reference section 3.1.4, Debian
N:   Policy Manual section 4.3, and Bug#755153 for details.
                    ^^^

The code in question is as follows:

  sub oxford_enumeration {
      my ($self, $conjunctive, @alternatives) = @_;

      return $EMPTY
        unless @alternatives;

      # remove and save last element
      my $final = pop @alternatives;

      my $maybe_comma = (@alternatives > 1 ? $COMMA : $EMPTY);

      my $text = $EMPTY;
      $text = join($COMMA . $SPACE, @alternatives) . "$maybe_comma $conjunctive "
        if @alternatives;

      $text .= $final;

      return $text;
  }

I don't think the "join($COMMA . $SPACE, @alternatives)" is right,
otherwise the first item in the list starts with a comma, as we can
see in the output quoted above.

(I would change it directly, but I can't immediately grok what is going
on with $maybe_comma, etc. so I don't want to break anything.)


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org / chris-lamb.co.uk
       `-

--- End Message ---
--- Begin Message --- 
Felix Lechner wrote:

> More significantly, I can no longer reproduce the bug with the
> development version in Git, per the output below.

Can confirm it is fixed in Git. Closing in CC.


Regards,

-- 
      ,''`.
     : :'  :     Chris Lamb
     `. `'`      lamby@debian.org 🍥 chris-lamb.co.uk
       `-

--- End Message ---
Reply to: