Your message dated Tue, 07 Sep 2021 10:05:04 +0000 with message-id <E1mNXyS-000GtC-Qn@fasolo.debian.org> and subject line Bug#992465: fixed in lintian 2.105.0 has caused the Debian Bug report #992465, regarding [lintian] systemd-service-file-outside-lib should not flag /usr/lib/systemd/system/ to be marked as done. This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact owner@bugs.debian.org immediately.) -- 992465: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=992465 Debian Bug Tracking System Contact owner@bugs.debian.org with problems
--- Begin Message ---
- To: Debian Bug Tracking System <submit@bugs.debian.org>
- Subject: [lintian] systemd-service-file-outside-lib should not flag /usr/lib/systemd/system/
- From: Peter Pentchev <roam@ringlet.net>
- Date: Thu, 19 Aug 2021 01:57:28 +0300
- Message-id: <162932737758.26812.10374962347251311112.reportbug@straylight.m.ringlet.net>
Package: lintian Version: 2.104.0 Severity: normal Tags: patch X-Debbugs-Cc: roam@debian.org Hi, Thanks a lot for all your work on Lintian! The systemd-service-file-outside-lib checks have, since 2015, flagged unit files found in the /usr/lib/systemd/system/ directory. It seems that at some point since then (I'm not exactly sure when), maybe because of the merged-/usr layout, maybe for other reasons, systemd on Debian has started actually paying attention to unit files found there. I noticed this almost accidentally, when I rebuilt (still only locally, although I do intend to upload it soon) my stunnel4 package with debhelper 13.4 as found in unstable now: as part of fixing #987989, debhelper now installs unit files in /usr/lib/systemd/system/ instead of /lib/systemd/system/; see: https://salsa.debian.org/debian/debhelper/-/commit/d70caa69c64b124e3611c967cfab93aef48346d8 So debhelper now produces packages that will place unit files into /usr, and I have just verified that the systemd in testing does, indeed, notice these files - I successfully enabled and started a stunnel@foo service through a stunnel@.service file in /usr/lib/systemd/system/. Maybe it's time to change the systemd-service-file-outside-lib check, at least partially? (the "do not place unit files in /etc" part is still very, very good advice for a package) What do you think about the attached patch? Tomorrow I will also send another one that adds (?:usr/)? to a couple of other regular expression checks (with some more work for at least one of them) so that these files are properly checked, too. G'luck, Peter -- System Information: Debian Release: 11.0 APT prefers testing APT policy: (990, 'testing'), (500, 'testing-debug'), (500, 'stable-security'), (500, 'oldoldstable') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 5.10.0-8-amd64 (SMP w/8 CPU threads) Locale: LANG=bg_BG.UTF-8, LC_CTYPE=bg_BG.UTF-8 (charmap=UTF-8), LANGUAGE not set Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled Versions of packages lintian depends on: ii binutils 2.35.2-2 ii bzip2 1.0.8-4 ii diffstat 1.64-1 ii dpkg 1.20.9 ii dpkg-dev 1.20.9 ii file 1:5.39-3 ii gettext 0.21-4 ii gpg 2.2.27-2 ii intltool-debian 0.35.0+20060710.5 ii libapt-pkg-perl 0.1.40 ii libarchive-zip-perl 1.68-1 ii libcapture-tiny-perl 0.48-1 ii libclass-xsaccessor-perl 1.19-3+b7 ii libclone-perl 0.45-1+b1 ii libconfig-tiny-perl 2.26-1 ii libcpanel-json-xs-perl 4.25-1+b1 ii libdata-dpath-perl 0.58-1 ii libdata-validate-domain-perl 0.10-1.1 ii libdevel-size-perl 0.83-1+b2 ii libdpkg-perl 1.20.9 ii libemail-address-xs-perl 1.04-1+b3 ii libfile-basedir-perl 0.08-1 ii libfile-find-rule-perl 0.34-1 ii libfont-ttf-perl 1.06-1.1 ii libhtml-html5-entities-perl 0.004-1.1 ii libipc-run3-perl 0.048-2 ii libjson-maybexs-perl 1.004003-1 ii liblist-compare-perl 0.55-1 ii liblist-moreutils-perl 0.430-2 ii liblist-utilsby-perl 0.11-1 ii libmoo-perl 2.004004-1 ii libmoox-aliases-perl 0.001006-1.1 ii libnamespace-clean-perl 0.27-1 ii libpath-tiny-perl 0.118-1 ii libperlio-gzip-perl 0.19-1+b7 ii libproc-processtable-perl 0.59-2+b1 ii libsereal-decoder-perl 4.018+ds-1+b1 ii libsereal-encoder-perl 4.018+ds-1+b1 ii libtext-glob-perl 0.11-1 ii libtext-levenshteinxs-perl 0.03-4+b8 ii libtext-markdown-discount-perl 0.12-1+b1 ii libtext-xslate-perl 3.5.8-1+b1 ii libtime-duration-perl 1.21-1 ii libtime-moment-perl 0.44-1+b3 ii libtimedate-perl 2.3300-2 ii libtry-tiny-perl 0.30-1 ii libtype-tiny-perl 1.012002-1 ii libunicode-utf8-perl 0.62-1+b2 ii liburi-perl 5.08-1 ii libxml-libxml-perl 2.0134+dfsg-2+b1 ii libyaml-libyaml-perl 0.82+repack-1+b1 ii lzip 1.22-3 ii lzop 1.04-2 ii man-db 2.9.4-2 ii patchutils 0.4.2-1 ii perl [libdigest-sha-perl] 5.32.1-4 ii t1utils 1.41-4 ii unzip 6.0-26 ii xz-utils 5.2.5-2 lintian recommends no packages. Versions of packages lintian suggests: ii binutils-multiarch 2.35.2-2 ii libtext-template-perl 1.59-1 -- no debconf informationFrom 85cb59f7bb09aaf97b0ea88f9ecd5c30cd453752 Mon Sep 17 00:00:00 2001 From: Peter Pentchev <roam@ringlet.net> Date: Thu, 19 Aug 2021 00:41:23 +0300 Subject: [PATCH] Allow files in /usr/lib/systemd/system/. --- lib/Lintian/Check/Systemd.pm | 3 --- t/recipes/checks/systemd/systemd-general/eval/tags | 1 - tags/s/systemd-service-file-outside-lib.tag | 5 ++--- 3 files changed, 2 insertions(+), 7 deletions(-) diff --git a/lib/Lintian/Check/Systemd.pm b/lib/Lintian/Check/Systemd.pm index 6f5ba7c3f..74a5c7eb6 100644 --- a/lib/Lintian/Check/Systemd.pm +++ b/lib/Lintian/Check/Systemd.pm @@ -291,9 +291,6 @@ sub check_systemd_service_file { $self->hint('systemd-service-file-outside-lib', $file) if $file =~ m{^etc/systemd/system/}; - $self->hint('systemd-service-file-outside-lib', $file) - if $file =~ m{^usr/lib/systemd/system/}; - unless ($file->is_open_ok || ($file->is_symlink && $file->link eq '/dev/null')) { diff --git a/t/recipes/checks/systemd/systemd-general/eval/tags b/t/recipes/checks/systemd/systemd-general/eval/tags index b09465675..c5aaa1ae5 100644 --- a/t/recipes/checks/systemd/systemd-general/eval/tags +++ b/t/recipes/checks/systemd/systemd-general/eval/tags @@ -4,7 +4,6 @@ systemd-general (binary): systemd-service-file-refers-to-obsolete-target usr/lib systemd-general (binary): systemd-service-file-refers-to-obsolete-target etc/systemd/system/systemd-general.test.service syslog.target systemd-general (binary): systemd-service-file-refers-to-obsolete-bindto usr/lib/systemd/system/systemd-general.test.service systemd-general (binary): systemd-service-file-refers-to-obsolete-bindto etc/systemd/system/systemd-general.test.service -systemd-general (binary): systemd-service-file-outside-lib usr/lib/systemd/system/systemd-general.test.service systemd-general (binary): systemd-service-file-outside-lib etc/systemd/system/systemd-general.test.service systemd-general (binary): systemd-service-file-outside-lib etc/systemd/system/fifo-pipe-as-init.service systemd-general (binary): systemd-service-file-missing-hardening-features usr/lib/systemd/system/systemd-general.test.service diff --git a/tags/s/systemd-service-file-outside-lib.tag b/tags/s/systemd-service-file-outside-lib.tag index 222bbf319..cffa68293 100644 --- a/tags/s/systemd-service-file-outside-lib.tag +++ b/tags/s/systemd-service-file-outside-lib.tag @@ -4,9 +4,8 @@ Check: systemd Explanation: The package ships a systemd service file outside <code>/lib/systemd/system/</code> . - Systemd in Debian searches for unit files in <code>/lib/systemd/system/</code> - and <code>/etc/systemd/system</code>. Notably, it does *not* look - in <code>/usr/lib/systemd/system/</code> for service files. + Systemd in Debian searches for unit files in <code>/lib/systemd/system/</code>, + <code>/usr/lib/systemd/system/</code>, and <code>/etc/systemd/system</code>. . System administrators should have the possibility to overwrite a service file (or parts of it, in newer systemd versions) by placing a -- 2.32.0Attachment: signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
- To: 992465-close@bugs.debian.org
- Subject: Bug#992465: fixed in lintian 2.105.0
- From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>
- Date: Tue, 07 Sep 2021 10:05:04 +0000
- Message-id: <E1mNXyS-000GtC-Qn@fasolo.debian.org>
- Reply-to: Chris Lamb <lamby@debian.org>
Source: lintian Source-Version: 2.105.0 Done: Chris Lamb <lamby@debian.org> We believe that the bug you reported is fixed in the latest version of lintian, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 992465@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Chris Lamb <lamby@debian.org> (supplier of updated lintian package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmaster@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Tue, 07 Sep 2021 09:43:56 +0000 Source: lintian Architecture: source Version: 2.105.0 Distribution: unstable Urgency: medium Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org> Changed-By: Chris Lamb <lamby@debian.org> Closes: 898867 927476 932870 935907 942013 947258 962601 968011 969398 969762 972181 972876 972878 974175 974575 976643 976681 977261 977332 977976 978144 978534 980247 980560 980824 980987 981163 981268 981279 981712 981932 981935 982322 982630 982834 983219 983598 984678 985064 986400 988591 991242 992465 993531 993651 993711 9768010 Changes: lintian (2.105.0) unstable; urgency=medium . * Summary of tag changes: + Added: - backgrounded-test-command - crossing-screens - duplicate-p3dist-override - elevated-privileges - illegal-variable - misplaced-systemd-tmpfiles - missing-conffile - no-versioned-debhelper-prerequisite - nodejs-missing-version-override - obsolete-vim-addon-manager - pypi-homepage - python-traceback-in-manpage - ruby-interpreter-is-deprecated - rubygem-homepage - rules-require-build-prerequisite - rust-boilerplate - source-contains-editor-backup-file - source-contains-patch-failure-file - source-contains-quilt-control-dir - superficial-tests - systemd-service-in-odd-location - systemd-tmpfile-in-var-run - unexpected-conffile - unknown-conffile-instruction - unmerged-usr - upstream-metadata-field-unknown - wrong-team + Removed: - ancient-standards-version - conffile-is-not-in-package - missing-build-dependency - missing-python-build-dependency - octal-permissions - package-lacks-versioned-build-depends-on-debhelper - package-needs-versioned-debhelper-build-depends - setgid-binary - setuid-binary - setuid-gid-binary - systemd-service-file-outside-lib - systemd-tmpfiles.d-outside-usr-lib . [ Chris Lamb ] * Check for Python tracebacks in manual pages, usually caused by failing help2man calls (and cause reproducibility issues). * Correct confusion between left and right parens that was leading to output such as ")2 errors)". * Bump Standards-Version to 4.6.0.1. . [ Felix Lechner ] * Implement usr-merge; flag files shipped in /bin, /sbin or /lib. * Flag systemd temporary files placed in /var/run. (Closes: #984678) * Do not repeat tag name when annotating hints. (Closes: #969398) * Refuse to read installable control data in national encodings. * Stop shipping modules in system path. (Closes: #968011) - Provide a dedicated, non-public executable to obtain the latest policy version from Lintian data. (See: #978672) * Flag the use of DEB_BUILD_MULTIARCH in some Debian files. (Closes: #983219) * For team-maintained packages, flag names in another team's name space. * Provide a generalized method to grant exemptions to package families (screens). - Exempt ELPA packaging scripts for Emacs modules from executable-in-usr-lib. (Closes: #974175) - Exempt GNAT's read-only .ali files from non-standard-file-perm. (Closes: #986400) * Treat NMU edge cases for non-consecutive-debian-revision. (Closes: #942013) * Recommend the newer php-markdown over libmarkdown-php when embedded. (Closes: #898867) * Convert possible-gpl-code-linked-with-openssl to a classification tag. (Closes: #972181) * Turn maybe-not-arch-all-binnmuable into a classification tag. * Combine, rename two confusing debhelper tags. (Closes: #977332) * Warn when trying to issue duplicate hints; provide more context to disambiguate similar hints. * Add --output-width; wrap EWI tag descriptions to width of output terminal otherwise. * Assume that all interactive terminals are hyperlink-capable, but change default to off. * Send all debugging and status information to STDERR. * Drop support for custom visibility levels in profiles. * Prefer spaces over commas as field separators in profiles. * Build test packages automatically when running tests. (Closes: #927476, #935907) * Use semantic versioning for the output of '--version'; omit Git hash from Lintian version strings. * Refer to new website in output. * Update manual references for the first time in almost two years. * Update the JSON data file for Debian policy releases; include all up to 4.6.0.1. * Drop UTF-8 PerlIO layers for STDOUT and STDERR from almost all executables and the test suite. (Closes: #972876, #972878) * Do not pretend to show hashbang in hint context for unusual interpreters. (Closes: #982630) * Treat Testsuite field as a comma-separated list for the teams pkg-perl and pkg-js. (Closes: #9768010) * Use current program names in help messages and version announcements. (Closes: #977261) * Allow tilde in names of installed JAR archives. (Closes: #976681) * Flag source packages that declare only tests with the 'superficial' restriction. (Closes: #932870) * Ignore SIGWINCH in the test suite. (Closes: #974575) * For manual pages, extract section information correctly from .TH header. (Closes: #962601) * Recognize Architecture and Classes as valid fields in d/tests/control. (Closes: #977976) * Restructure tags for file permissions; combine tags for setuid/setgid executables. * Detect Rust boilerplate in package descriptions. (See: !344) * Do not fail on dangling symlinks when looking for obsolete, missing or invalid content. (Closes: #978534) * Always print full path to patch files. (Closes: #980247) * Tolerate manual pages for subcommands when main command is documented. (Closes: #947258) * Tighten regex for no-op-testsuite to stop false positives. (Closes: #980824) * Allow environment prefix when recognizing 'dh' sequencer. (Closes: #981712) * Ignore build profiles when requiring dh helper for Python prerequisites. (Closes: #991242) * Ignore build profiles when flagging use of py3versions in d/rules. (Closes: #978144) * Do not flag Python3 entry point definitions as out-of-place documentation. (Closes: #981268) * Flag duplicates in d/py3dist-overrides. (Closes: #980987) * Flag PyPI homepages in source control files. (Closes: #981932) * Flag Rubygem homepages in source control files. (Closes: #981935) * Accept the virtual package dh-sequence-dkms as B-D for 'dh --with-dkms'. (Closes: #982834) * Drop reference to archive keyring from package-installs-apt-sources. (Closes: #983598) * Read error message from Config::Tiny via the advertised mechanism. (Closes: #985064) * Add 'utils.h' to the list of overly generic headers. (Closes: #982322) * Drop package file names from tag context for unknown-field. (Closes: #980560) * Flag backgrounded Test-Commands in autopkgtest declarations. (Closes: #988591) * For multi-component sources, always drop common prefixes for sub-components. (Closes: #976643) * Accept more than two components in architecture wildcards for package relationships. (Closes: #981163) * Add Breaks: lintian-brush (<< 0.88) to debian/control due to failing autopkgtests. * Implement two perltidy policies. * Implement 87 perlcritic policies; disregard four others. * Ignore special attributes like 'remove-on-upgrade' in DEBIAN/conffiles. (Closes: #993531, #993711) * Read checks separately from ./lib and ./checks; forego symbolic link. (Closes: #993651) . [ Simon McVittie ] * Update lists of registered build-profile names . [ Paul Wise ] * spelling: Add several corrections * Upgrade superficial-tests tag to warning . [ Xavier Guimard ] * Verify that nodejs module does not use semantic-release * Fix and simplify search when parsing pkg-js-autopkgtest files. (Closes: #981279) . [ Emmanuel Bourg ] * Detect obsolete Servlet API 3.1. (See: !348) . [ Alexandre Rossi ] * Recognize empty and very small files as architecture-independent. . [ Jelmer Vernooij ] * Fix typo: valgring => valgrind. * Fix archive section mapping for rust development packages. * Check upstream field names in upstream metadata. (Closes: #969762) . [ gregor herrmann ] * Add another spelling correction. . [ Victor Westerhuis ] * Add --no-rename as a recognized option for dpkg-divert. . [ Brian Murray ] * Recognize Ubuntu's next release, named 'impish', among the known-dists. . [ Louis-Philippe Véronneau ] * Add check for obsolete installation prerequisite vim-addon-manager. . [ Fatih Altun ] * Add profile for Pardus Linux . [ Antonio Terceiro ] * Stop suggesting ruby-interpreter as a prerequisite. (See: !365) * Warn about the outdated prerequisite ruby-interpreter. (See: !365) . [ Peter Pentchev ] * Adjust to debhelper's new install location for systemd service files. (Closes: #992465) Checksums-Sha1: 58e4f300efdb5d15d33bd222810e62763322ed15 2469 lintian_2.105.0.dsc 908caf020432d356af1cadf783ab7ae3c70ed219 2052004 lintian_2.105.0.tar.xz 99f67f487c1d0889792d3e3aaf674802d36d36a9 6551 lintian_2.105.0_amd64.buildinfo Checksums-Sha256: 3738a6e5336e487be983d6ee97d87fb128a3871c81dc3bc3f87f42e41d06037d 2469 lintian_2.105.0.dsc d9fa12b4c11cc6aed94fe2a27d4586d5e28477373ef0074503ffd978d0550cfa 2052004 lintian_2.105.0.tar.xz 8ac437e27c42c7f2aee008941a3418c18ccf710e2196ed5af925cd20c8cb2a24 6551 lintian_2.105.0_amd64.buildinfo Files: 611d09270ef51d30ca91280d488ef08c 2469 devel optional lintian_2.105.0.dsc 602f173427c42bade1f85d81b028810f 2052004 devel optional lintian_2.105.0.tar.xz dfe817dcc03489684c9c29045c9be179 6551 devel optional lintian_2.105.0_amd64.buildinfo -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEwv5L0nHBObhsUz5GHpU+J9QxHlgFAmE3NmAACgkQHpU+J9Qx HljL9A/+MRC4Z5UhmdkxxU+mPkWJEckuJS1ALhp3jJ0CzRp2gOdigcRr+ALmP0j/ YxcQfyQw5VJY3+OAEX/aF+9xYwxt+Jtl+iOs2x3iiXSuDzayUGFHeLOGhF39hovM JVIjbvZ9T/1F8mH68tzLElKF+7NEL+AGp947+zA3iHQmOWAXIfFHdesmIN2v7OX2 FVEN3Z9NGHtiwV82WrS4Tszky0X+hCDsvQvAWe5j+ao1w5uRmQZvRqXkVB2F4uW/ JheAUCbnJlZSZ4Ai4vWCTCvstQ47QEhtuM7fiZB8NAGwmGbj4X6m/SZm+bSG9kkH Sh66eNGgxbCSidsxXBs5FCngl2bBH6F1k0WdK+FZJWN/0ixXRthAhctabaUS/nOu TLMNYc4KMWweqWOQlvmNsziXgzJU3K7sDwysId8r43HLsPcSpr/7cv1s3N55kxoU ImurSMcNcRBP5jhzwlg91l32yfcNYYP7FEn5CrAJrZlLFPQLlyiaeb6ErIDhhnxO gpNIR7WEvFlcQGR8crV3HOdre5hFeC1SMFiP5nKA4rrdYU8YV9FbWZI28s7jQgdd waBsfutkCVs8EQmPnIwYs48mp3VgdYLerHzC5CtTtRnmJt9MFQNgOI4g5Dw929W4 OvnebyUFd48qvbX/JuPflEn3aqLpxZs58gRAoiUk33RHIGK7E2c= =yO7Z -----END PGP SIGNATURE-----
--- End Message ---