[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#889816: lintian: Complain when epoch has been bumped but upstream version did not go backwards



Hi,

On Tue, 08 May 2018, Mattia Rizzolo wrote:
> > > I think this warning was not in place yet when you made that mistake.
> > 
> > This warning was added in 2007 so it's likely I just missed it.
> 
> I doubt you missed it.
> latest-debian-changelog-entry-without-new-version is really what it
> says: the overall version decreases.  You can see it when you use a
> 'backports like' without targetting backports.
> 
> If you bump an epoch you should never see it.

That's not true, the code drops the epoch:
                tag 'latest-debian-changelog-entry-without-new-version'
                  unless versions_gt(
                    $first_version =~ s/^([^:]+)://r,
                    $second_version =~ s/^([^:]+)://r
                  )
                  or $entries[0]->Changes =~ /backport/i
                  or $entries[0]->Source ne $entries[1]->Source;

This is a recent change (2.5.75):
  * checks/changelog-file.desc:
    + [CL] When checking latest-debian-changelog-entry-without-new-version
      ignore any change of epoch.  (Closes: #889991)

IMO reusing this tag to implement what was requested in #889991 was
a bad decision. The two problems are not really related. The fact that
the version (with epoch included!) is not increasing is a real problem
except when we backport.

The fact that we are reusing a version (with epoch stripped) that already
existed in the past is another problem. I'm going to reopen #889991.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/


Reply to: