[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 01/01: Detect wasm prebuilt file



This is an automated email from the git hooks/post-receive script.

rouca pushed a commit to branch wasm
in repository lintian.

commit 6182305d061d1042e3a2008b43f9994a3e55dbd6
Author: Bastien ROUCARIÈS <roucaries.bastien+debian@gmail.com>
Date:   Fri Feb 2 10:48:37 2018 +0100

    Detect wasm prebuilt file
    
    wasm have the potential to be like minified javascript.
    
    Detect early
---
 checks/cruft.desc                  | 12 ++++++++++++
 data/cruft/warn-file-type          |  1 +
 debian/changelog                   |  1 +
 t/tests/cruft-wasm/desc            | 10 ++++++++++
 t/tests/cruft-wasm/pre_upstream    | 11 +++++++++++
 t/tests/cruft-wasm/tags            |  2 ++
 t/tests/cruft-wasm/upstream/README |  1 +
 7 files changed, 38 insertions(+)

diff --git a/checks/cruft.desc b/checks/cruft.desc
index 40c6cae..ab55382 100644
--- a/checks/cruft.desc
+++ b/checks/cruft.desc
@@ -537,6 +537,18 @@ Info: The source tarball contains a prebuilt binary for Microsoft Windows.
  the upstream distribution instead.  If not, you may want to ask upstream
  to provide source-only tarballs.
 
+Tag: source-contains-prebuilt-wasm-binary
+Severity: pedantic
+Certainty: certain
+Info: The source tarball contains a prebuilt binary wasm object.
+ They are usually provided for the convenience of users.  These files
+ usually just take up space in the tarball and need to be rebuilt from
+ source.
+ .
+ Check if upstream also provides source-only tarballs that you can use as
+ the upstream distribution instead.  If not, you may want to ask upstream
+ to provide source-only tarballs.
+
 Tag: source-contains-waf-binary
 Severity: important
 Certainty: certain
diff --git a/data/cruft/warn-file-type b/data/cruft/warn-file-type
index 22b9c36..dd60910 100644
--- a/data/cruft/warn-file-type
+++ b/data/cruft/warn-file-type
@@ -15,3 +15,4 @@ source-contains-prebuilt-javascript-object  ~~ .*
 source-contains-prebuilt-python-object      ~~ ^python \s \d(\.\d+)? \s byte-compiled                                    ~~ .*                                ~~ s/(?i)(?:\.cpython-\d{2}|\.pypy)?\.py[co]$/.py/
 source-contains-prebuilt-silverlight-object ~~ ^Zip \s archive \s data                                                   ~~ (?i)\.xac$
 source-contains-prebuilt-windows-binary     ~~ \b(?:PE(?:32|64)|(?:MS-DOS|COFF)\s executable)\b
+source-contains-prebuilt-wasm-binary        ~~ ^WebAssembly \s \(wasm\) \s binary \s module
diff --git a/debian/changelog b/debian/changelog
index 61ca98f..2bdb566 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -7,6 +7,7 @@ lintian (2.5.73) UNRELEASED; urgency=medium
       check "src/foo/bar.js".  (Closes: #832027)
     + [CL] Check for upstream tarballs that ship examples but none is
       installed in any binary package.  (Closes: #539326)
+    + [BR] Check for wasm file. (Closes: #889102)
   * checks/debian-source-dir.desc:
     + [CL] Upgrade severity of missing-debian-source-format from wishlist
       ("I") to normal ("W").  (Closes: #702671)
diff --git a/t/tests/cruft-wasm/desc b/t/tests/cruft-wasm/desc
new file mode 100644
index 0000000..d9cf8dd
--- /dev/null
+++ b/t/tests/cruft-wasm/desc
@@ -0,0 +1,10 @@
+Testname: cruft-wasm
+Version: 1.0-1
+Description: Misc errors related to wasm
+Skeleton: pedantic
+Options: --pedantic -I -E
+Architecture: any
+Type: non-native
+Test-For:
+ source-contains-prebuilt-wasm-binary
+Test-Depends: file (>= 1:5.32)
diff --git a/t/tests/cruft-wasm/pre_upstream b/t/tests/cruft-wasm/pre_upstream
new file mode 100755
index 0000000..12344f9
--- /dev/null
+++ b/t/tests/cruft-wasm/pre_upstream
@@ -0,0 +1,11 @@
+#!/bin/sh
+#
+# Create all the various junk that shouldn't exist in the diff so that we can
+# trigger all the tags.
+
+set -e
+dir="$1"
+srcdir="$1"
+
+printf "\0asm\001\0\0\0" > "$srcdir/fake.wasm"
+
diff --git a/t/tests/cruft-wasm/tags b/t/tests/cruft-wasm/tags
new file mode 100644
index 0000000..3401a43
--- /dev/null
+++ b/t/tests/cruft-wasm/tags
@@ -0,0 +1,2 @@
+P: cruft-wasm source: debian-watch-does-not-check-gpg-signature
+P: cruft-wasm source: source-contains-prebuilt-wasm-binary fake.wasm
diff --git a/t/tests/cruft-wasm/upstream/README b/t/tests/cruft-wasm/upstream/README
new file mode 100644
index 0000000..a6a4fce
--- /dev/null
+++ b/t/tests/cruft-wasm/upstream/README
@@ -0,0 +1 @@
+This include fake wasm file

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: