[lintian] 01/01: Check for packages containing upstart configuration under /etc/init/. (Closes: #825348)
This is an automated email from the git hooks/post-receive script.
lamby pushed a commit to branch master
in repository lintian.
commit 9ce5009915a499f92968976d68c182aa0b96a216
Author: Chris Lamb <lamby@debian.org>
Date: Fri Jul 14 11:40:07 2017 +0100
Check for packages containing upstart configuration under /etc/init/. (Closes: #825348)
---
checks/files.desc | 10 ++++++++++
checks/files.pm | 4 ++++
debian/changelog | 2 ++
t/tests/files-foo-in-bar/debian/debian/dirs | 1 +
t/tests/files-foo-in-bar/debian/debian/install | 1 +
t/tests/files-foo-in-bar/desc | 1 +
t/tests/files-foo-in-bar/tags | 1 +
7 files changed, 20 insertions(+)
diff --git a/checks/files.desc b/checks/files.desc
index 7113ac3..4d7956a 100644
--- a/checks/files.desc
+++ b/checks/files.desc
@@ -1741,3 +1741,13 @@ Info: The package is architecture-dependent, ships a shared library in
same package, but this package does not contain any programs.
.
Please remove the <tt>Multi-Arch: foreign</tt> stanza.
+
+Tag: package-installs-deprecated-upstart-configuration
+Severity: normal
+Certainty: certain
+Info: The package installs files into the <tt>/etc/init</tt>
+ directory which is used by Upstart, a replacement for the <tt>/sbin/init</tt>
+ daemon which handles starting of tasks and services during boot, etc.
+ .
+ However, Upstart was removed in Debian "stretch" and these files are thus no
+ longer useful and should be removed.
diff --git a/checks/files.pm b/checks/files.pm
index 6b594d6..a2baf4c 100644
--- a/checks/files.pm
+++ b/checks/files.pm
@@ -531,6 +531,10 @@ sub run {
elsif ($fname =~ m,^etc/gconf/schemas/\S,) {
tag 'package-installs-into-etc-gconf-schemas', $file;
}
+ # ---------------- /etc/init
+ elsif ($fname =~ m,^etc/init/\S,) {
+ tag 'package-installs-deprecated-upstart-configuration', $file;
+ }
# ---------------- /etc/init.d
elsif ( $fname =~ m,^etc/init\.d/\S,
and $fname !~ m,^etc/init\.d/(?:README|skeleton)$,
diff --git a/debian/changelog b/debian/changelog
index fb2723c..e74fbcc 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -38,6 +38,8 @@ lintian (2.5.52) UNRELEASED; urgency=medium
+ [CL] Add .yml to the list of file extensions to avoid false
positives when emitting extra-license-file, with testcase. Thanks
to Rene Engelhard for the report. (Closes: #856137)
+ + [CL] Check for packages containing upstart configuration under
+ /etc/init. Thanks to Paul Wise for the report. (Closes: #825348)
* checks/init.d.desc:
+ [CL] Add an example snippet to explain how to prevent emission
of init.d-script-sourcing-without-test.
diff --git a/t/tests/files-foo-in-bar/debian/debian/dirs b/t/tests/files-foo-in-bar/debian/debian/dirs
index a5388a4..e8759c9 100644
--- a/t/tests/files-foo-in-bar/debian/debian/dirs
+++ b/t/tests/files-foo-in-bar/debian/debian/dirs
@@ -1,5 +1,6 @@
etc/apt/preferences.d
etc/apt
+etc/init
bin/foo
mnt/foo
tmp/foo
diff --git a/t/tests/files-foo-in-bar/debian/debian/install b/t/tests/files-foo-in-bar/debian/debian/install
index 50d65b4..153db98 100644
--- a/t/tests/files-foo-in-bar/debian/debian/install
+++ b/t/tests/files-foo-in-bar/debian/debian/install
@@ -3,6 +3,7 @@ bar emul
bar etc/apt/preferences.d
bar etc/apt/sources.list.d
bar etc/gconf/schemas/
+bar etc/init
bar etc/rc.boot
bar etc/rc.d
bar etc/udev/rules.d
diff --git a/t/tests/files-foo-in-bar/desc b/t/tests/files-foo-in-bar/desc
index 06e8fd8..a51ae56 100644
--- a/t/tests/files-foo-in-bar/desc
+++ b/t/tests/files-foo-in-bar/desc
@@ -29,6 +29,7 @@ Test-For:
package-installs-file-to-usr-x11r6
package-installs-apt-preferences
package-installs-apt-sources
+ package-installs-deprecated-upstart-configuration
package-installs-into-etc-gconf-schemas
package-installs-into-etc-rc.boot
package-installs-into-etc-rc.d
diff --git a/t/tests/files-foo-in-bar/tags b/t/tests/files-foo-in-bar/tags
index da45a3a..1166856 100644
--- a/t/tests/files-foo-in-bar/tags
+++ b/t/tests/files-foo-in-bar/tags
@@ -92,6 +92,7 @@ W: files-foo-in-bar: non-multi-arch-lib-dir usr/lib32/
W: files-foo-in-bar: non-multi-arch-lib-dir usr/lib64/
W: files-foo-in-bar: non-multi-arch-lib-dir usr/libx32/
W: files-foo-in-bar: non-standard-dir-in-usr usr/foo/
+W: files-foo-in-bar: package-installs-deprecated-upstart-configuration etc/init/bar
W: files-foo-in-bar: package-installs-into-etc-gconf-schemas etc/gconf/schemas/bar
W: files-foo-in-bar: package-installs-into-obsolete-dir etc/dhcp3/ : ^etc/dhcp3/ -> etc/dhcp (see also https://bugs.debian.org/673029)
W: files-foo-in-bar: package-installs-into-obsolete-dir etc/dhcp3/bar : ^etc/dhcp3/ -> etc/dhcp (see also https://bugs.debian.org/673029)
--
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git
Reply to: