[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#818962: [lintian] Proposed patches for php checks



Hi Jakub and Mathieu,

I think the lintian should not allow dependency on phpX.Y-<foo>, but
only on php-<foo> (people can still override that), because we want
packages to transition between different PHP versions by default.

I'll review Mathieu's patches tomorrow and update them accordingly.

Cheers,
-- 
Ondřej Surý <ondrej@sury.org>
Knot DNS (https://www.knot-dns.cz/) – a high-performance DNS server

On Wed, Apr 20, 2016, at 22:40, Jakub Wilk wrote:
> Hi Mathieu!
> 
> Thanks for the patches.
> 
> * Mathieu Parent <math.parent@gmail.com>, 2016-04-19, 12:10:
> > Info: Packages with PHP scripts must depend on a phpX-cli package such as
> >- php5-cli.  Note that a dependency on a php-cgi package (such as php5-cgi)
> >- is needlessly strict and forces the user to install a package that isn't
> >- needed.
> >+ php-cli or php7.0-cli.  Note that a dependency on a php-cgi package (such
> >+ as php-cgi or php7.0-cgi) is needlessly strict and forces the user to
> >+ install a package that isn't needed.
> 
> Hmm, that's not the description Ondřej proposed...
> Also, "php-cgi package (such as php-cgi ...)" sounds awkward.
> 
> >-php     => /usr/bin, php(\d+), php$1-cli, 5, @NO_DEFAULT_DEPS@
> >+php     => /usr/bin, php(\d+), php$1-cli, 5, php-cli
> 
> Shouldn't it be "php([\d.]+)" and s/5/7.0/?
> 
> >Subject: [PATCH 2/6] dh-php5 is replaced by dh-php, and php5-dev by php-dev
> >Subject: [PATCH 3/6] php-foo.ini is now in /etc/php/*/mods-available/
> 
> Applied!
> 
> >Subject: [PATCH 4/6] Updated checks.pot
> 
> We'll update checks.pot later...
> 
> >Subject: [PATCH 5/6] Fix refresh-debhelper-data (dists/sid/Contents-i386.gz is
> > no more)
> >Subject: [PATCH 6/6] Refresh debhelper data
> 
> Applied!
> 
> -- 
> Jakub Wilk


Reply to: