[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[lintian] 01/01: L::Check: Remove work-around for Email::Valid bug (#663663)



This is an automated email from the git hooks/post-receive script.

jwilk pushed a commit to branch master
in repository lintian.

commit f990c7d6e9740a7a04ef457b41c8fdabf0bbe705
Author: Jakub Wilk <jwilk@debian.org>
Date:   Mon Jan 11 11:48:05 2016 +0100

    L::Check: Remove work-around for Email::Valid bug (#663663)
    
    This bug is now fixed even in oldstable.
---
 debian/changelog     |  4 ++++
 lib/Lintian/Check.pm | 13 +------------
 2 files changed, 5 insertions(+), 12 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index fa2dd55..75f5bcc 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -31,6 +31,10 @@ lintian (2.5.40) UNRELEASED; urgency=medium
   * data/spelling/corrections*:
     + [JW] Add more corrections.
 
+  * lib/Lintian/Check.pm:
+    + [JW] Remove work-around for Email::Valid bug (#663663), which is now
+      fixed even in oldstable.
+
  -- Niels Thykier <niels@thykier.net>  Sun, 27 Dec 2015 09:43:24 +0000
 
 lintian (2.5.39.1) unstable; urgency=medium
diff --git a/lib/Lintian/Check.pm b/lib/Lintian/Check.pm
index a6afa0a..618430b 100644
--- a/lib/Lintian/Check.pm
+++ b/lib/Lintian/Check.pm
@@ -182,18 +182,7 @@ sub check_maintainer {
         if (not $malformed and not Email::Valid->address($mail)) {
             # Either not a valid email or possibly missing a comma between
             # two entries.
-            $malformed = 1;
-            if ($mail =~ /^0/) {
-                # Email::Valid does not handle emails starting with "0" too
-                # well.  So replace it with a "1", which Email::Valid cannot
-                # misinterpret as a "false-value".
-                # - Fixed in libemail-valid-perl/0.187-2, this work around
-                #   can be dropped when the fix is in stable.
-                my $copy = $mail;
-                $copy =~ s/^0/1/;
-                $malformed = 0 if Email::Valid->address($copy);
-            }
-            tag "$field-address-malformed", $maintainer if $malformed;
+            tag "$field-address-malformed", $maintainer;
         }
         if ($mail =~ /(?:localhost|\.localdomain|\.localnet)$/) {
             tag "$field-address-is-on-localhost", $maintainer;

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/lintian/lintian.git


Reply to: