Bug#803519: lintian: Search for the string "legal" in every file, as it is gererally misused

[Bjarni Ingi Gislason <bjarniig@rhi.hi.is>]

Package: lintian
Version: 2.5.30+deb8u4
Severity: wishlist

Dear Maintainer,

  The word "(il)legal" is too often used in a wrong sense, both in
documentation, diagnostic messages, and in a code as a part of a name
of an identifier.

  This should be changed to a correct name, like "(in)valid", which is
mentioned in the "GNU Coding Standard" and which is just common sense.

  "Lintian" should therefor search for this text string in every file
and report it.  Files with all correct use of "(il)legal" can then
later be put on the "overrides" list, if they are unchanged from the
last run of "lintian".

-- System Information:
Debian Release: 8.2
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'stable-updates'), (500, 'proposed-updates')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.7-ckt11-u5 (SMP w/2 CPU cores)
Locale: LANG=is_IS.iso88591, LC_CTYPE=is_IS.iso88591 (charmap=ISO-8859-1)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages lintian depends on:
ii  binutils                       2.25-5
ii  bzip2                          1.0.6-7+b3
ii  diffstat                       1.58-1
ii  file                           1:5.22+15-2
ii  gettext                        0.19.3-2
ii  hardening-includes             2.6
ii  intltool-debian                0.35.0+20060710.1
ii  libapt-pkg-perl                0.1.29+b2
ii  libarchive-zip-perl            1.39-1
ii  libclass-accessor-perl         0.34-1
ii  libclone-perl                  0.37-1+b1
ii  libdpkg-perl                   1.17.25
ii  libemail-valid-perl            1.195-1
ii  libfile-basedir-perl           0.03-1
ii  libipc-run-perl                0.92-1
ii  liblist-moreutils-perl         0.33-2+b1
ii  libparse-debianchangelog-perl  1.2.0-1.1
ii  libtext-levenshtein-perl       0.11-1
ii  libtimedate-perl               2.3000-2
ii  liburi-perl                    1.64-1
ii  man-db                         2.7.0.2-5
ii  patchutils                     0.3.3-1
ii  perl [libdigest-sha-perl]      5.20.2-3+deb8u1
ii  t1utils                        1.38-4

Versions of packages lintian recommends:
pn  libperlio-gzip-perl             <none>
ii  perl                            5.20.2-3+deb8u1
ii  perl-modules [libautodie-perl]  5.20.2-3+deb8u1

Versions of packages lintian suggests:
pn  binutils-multiarch     <none>
ii  dpkg-dev               1.17.25
ii  libhtml-parser-perl    3.71-1+b3
ii  libtext-template-perl  1.46-1
pn  libyaml-perl           <none>
ii  xz-utils               5.1.1alpha+20120614-2+b3

-- Configuration Files:
/etc/lintianrc changed [not included]

-- no debconf information

-- 
Bjarni I. Gislason