Bug#733598: Warn about packages shipping config.h in /usr/include/foo

[Daniel Pocock <daniel@pocock.com.au>]

Package: lintian
Severity: wishlist

Some packages ship an autotools config.h in /usr/include/foo/config.h

Here is a list of such packages:

http://packages.debian.org/search?searchon=contents&keywords=config.h&mode=exactfilename&suite=stable&arch=any

This can cause problems if one autotools-based package A builds by using
a dev package from another package B.  Specifically, situations arise
where config.h from A and B are both included in the same compiler
invocation and warnings are generated about redefinitions of PACKAGE_NAME

Here is an example:

https://buildd.debian.org/status/fetch.php?pkg=resiprocate&arch=i386&ver=1.9.0~beta8-5&stamp=1388333982

In file included from dtls_wrapper/DtlsSocket.hxx:2:0,
                 from FlowDtlsSocketContext.hxx:15,
                 from FlowDtlsSocketContext.cxx:14:
../config.h:105:0: warning: "PACKAGE_NAME" redefined [enabled by default]
 #define PACKAGE_NAME "resiprocate"
 ^
In file included from /usr/include/srtp/aes.h:49:0,
                 from /usr/include/srtp/prng.h:14,
                 from /usr/include/srtp/crypto_kernel.h:50,
                 from /usr/include/srtp/srtp.h:53,
                 from FlowDtlsSocketContext.hxx:12,
                 from FlowDtlsSocketContext.cxx:14:
/usr/include/srtp/config.h:125:0: note: this is the location of the previous definition
 #define PACKAGE_NAME ""
 ^


In this case, it is a build of resiprocate, and the dependency package libsrtp0-dev is providing a rogue config.h in /usr/include/srtp/config.h