[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[SCM] Debian package checker branch, lab-refactor, updated. 2.5.3-169-ga55a287



The following commit has been merged in the lab-refactor branch:
commit a55a28730438fbdf7f4ad674ebbeb2a2a9ac4132
Author: Niels Thykier <niels@thykier.net>
Date:   Thu Oct 27 19:14:10 2011 +0200

    Fixed Pod coverage of L::Lab and hid the L::L::Entry constructor
    
    Signed-off-by: Niels Thykier <niels@thykier.net>

diff --git a/lib/Lintian/Lab.pm b/lib/Lintian/Lab.pm
index 17611f1..f8a29cb 100644
--- a/lib/Lintian/Lab.pm
+++ b/lib/Lintian/Lab.pm
@@ -269,7 +269,7 @@ sub get_package {
             $pkg_src_version = $e->{'source-version'}//$pkg_version;
         }
         $dir = $self->_pool_path ($pkg_name, $pkg_type, $pkg_version, $pkg_arch);
-        push @entries, Lintian::Lab::Entry->new ($self, $pkg_name, $pkg_version, $pkg_arch, $pkg_type, $pkg_path, $pkg_src, $pkg_src_version, $dir);
+        push @entries, Lintian::Lab::Entry->_new ($self, $pkg_name, $pkg_version, $pkg_arch, $pkg_type, $pkg_path, $pkg_src, $pkg_src_version, $dir);
     } else {
         # clear $pkg_arch if it is a source package - it simplifies
         # the search code below
@@ -284,7 +284,7 @@ sub get_package {
             return if defined $pkg_arch && $a ne $pkg_arch;
             $pp = $entry->{'file'};
             $dir = $self->_pool_path ($pkg_name, $pkg_type, $v, $a);
-            push @entries,  Lintian::Lab::Entry->new ($self, $pkg_name, $v, $a, $pkg_type, $pp, $entry->{'source'}, $entry->{'source-version'}//$v, $dir);
+            push @entries,  Lintian::Lab::Entry->_new ($self, $pkg_name, $v, $a, $pkg_type, $pp, $entry->{'source'}, $entry->{'source-version'}//$v, $dir);
         };
         my @sk = ($pkg_name);
         push @sk, $pkg_version if defined $pkg_version;
@@ -314,7 +314,7 @@ sub visit_packages {
             my $pp = $me->{'file'};
             my $pkg_src = $me->{'source'}//$pkg_name;
             my $pkg_src_version = $me->{'source-version'}//$pkg_version;
-            my $lentry = Lintian::Lab::Entry->new ($self, $pkg_name, $pkg_version, $pkg_arch,
+            my $lentry = Lintian::Lab::Entry->_new ($self, $pkg_name, $pkg_version, $pkg_arch,
                                                    $pkg_type, $pp, $pkg_src, $pkg_src_version, $dir);
             $visitor->($lentry, $pkg_name, $pkg_version, $pkg_arch);
         };
@@ -393,16 +393,19 @@ sub _pool_path {
     return "$dir/pool/$p";
 }
 
-# lab->generate_diffs(@lists)
-#
-# Each member of @lists must be a Lintian::Lab::Manifest.
-#
-# The lab will generate a diff between the given member and its
-# state for the given package type.  The diffs are returned in the
-# same order as they appear in @lists.
-#
-# The diffs are valid until the original list is modified or a
-# package is added or removed to the lab.
+=item lab->generate_diffs(@lists)
+
+Each member of @lists must be a Lintian::Lab::Manifest.
+
+The lab will generate a diff between the given member and its state
+for the given package type.  The diffs are returned in the same order
+as they appear in @lists.
+
+The diffs are valid until the original list is modified or a package
+is added or removed to the lab.
+
+=cut
+
 sub generate_diffs {
     my ($self, @lists) = @_;
     my $labdir = $self->dir;
diff --git a/lib/Lintian/Lab/Entry.pm b/lib/Lintian/Lab/Entry.pm
index 31f023b..9500c1e 100644
--- a/lib/Lintian/Lab/Entry.pm
+++ b/lib/Lintian/Lab/Entry.pm
@@ -77,7 +77,8 @@ our (@EXPORT, @EXPORT_OK, %EXPORT_TAGS);
     @{ $EXPORT_TAGS{constants} }
 );
 
-sub new {
+# private constructor (called by Lintian::Lab)
+sub _new {
     my ($type, $lab, $pkg_name, $pkg_version, $pkg_arch, $pkg_type, $pkg_path, $pkg_src, $pkg_src_version, $base_dir) = @_;
     my $self = {};
     bless $self, $type;
diff --git a/t/scripts/pod-coverage.t b/t/scripts/pod-coverage.t
index 34298d6..a0a8f2a 100755
--- a/t/scripts/pod-coverage.t
+++ b/t/scripts/pod-coverage.t
@@ -20,6 +20,10 @@ our %MODULES =
      'Lintian::Data'               => [],
      'Lintian::DepMap'             => [],
      'Lintian::DepMap::Properties' => [],
+     'Lintian::Lab'                => [],
+     'Lintian::Lab::Entry'         => [],
+     'Lintian::Lab::Manifest'      => [],
+     'Lintian::Lab::ManifestDiff'  => [],
      'Lintian::Profile'            => [],
      'Lintian::Processable'        => [],
      'Lintian::ProcessableGroup'   => [],

-- 
Debian package checker


Reply to: