[SCM] Debian package checker branch, master, updated. 2.3.3-60-g921af45
The following commit has been merged in the master branch:
commit 921af4557427d28d297042ba720e712a0a227603
Author: Raphael Geissert <atomo64@gmail.com>
Date: Sun Mar 21 11:53:07 2010 -0600
Check for packages shipping files literally called '*'
* checks/files{,.desc}:
+ [RG] New check for packages shipping files literally called '*'
(star symbol). Thanks, Niels Thykier. (Closes: #574771)
diff --git a/checks/files b/checks/files
index bcbbf28..e1f2071 100644
--- a/checks/files
+++ b/checks/files
@@ -775,6 +775,9 @@ foreach my $file (sort keys %{$info->index}) {
if ($file =~ m,\s+\z,) {
tag "file-name-ends-in-whitespace", "$file";
}
+ if ($file =~ m,/\*\z,) {
+ tag "star-file", $file;
+ }
# ---------------- misplaced lintian overrides
my $tmp = quotemeta($pkg);
diff --git a/checks/files.desc b/checks/files.desc
index ff71bc9..fefa174 100644
--- a/checks/files.desc
+++ b/checks/files.desc
@@ -1145,3 +1145,10 @@ Info: This binary package appears to be empty, and its description does
If the package is deliberately empty, pleaes mention in the package long
description one of the phrases "meta-package," "dummy," "dependency
package," "empty package," or "virtual package."
+
+Tag: star-file
+Severity: important
+Certainty: possible
+Info: The given file is literally installed as <tt>*</tt> (star
+ symbol). Normally this indicates a mistake in the installation
+ process of the package either when creating symlinks or renaming files.
diff --git a/debian/changelog b/debian/changelog
index dde5f57..856a9d5 100755
--- a/debian/changelog
+++ b/debian/changelog
@@ -7,6 +7,7 @@ lintian (2.3.4) UNRELEASED; urgency=low
- empty-binary-package
- missing-debian-source-format
- possible-new-upstream-release-without-new-version
+ - star-file
- unknown-file-in-debian-source
- unknown-source-format
@@ -55,6 +56,8 @@ lintian (2.3.4) UNRELEASED; urgency=low
standard files and don't declare themselves to be metapackages or
other types of dummy packages. Based on a patch from Luca
Falavigna. (Closes: #569220)
+ + [RG] New check for packages shipping files literally called '*'
+ (star symbol). Thanks, Niels Thykier. (Closes: #574771)
* checks/init.d:
+ [RA] Exclude symlinks to upstart-job from init script syntax checks.
Based on a patch by Jos Boumans. (Closes: #569492)
diff --git a/t/tests/files-general/debian/debian/rules b/t/tests/files-general/debian/debian/rules
index 7069dab..1ce5593 100755
--- a/t/tests/files-general/debian/debian/rules
+++ b/t/tests/files-general/debian/debian/rules
@@ -5,6 +5,11 @@ tmp = $(CURDIR)/debian/$(shell dh_listpackages)
%:
dh $@
+override_dh_install:
+ dh_install
+ mkdir -p $(tmp)/usr/share/foo
+ touch $(tmp)/usr/share/foo/'*'
+
override_dh_fixperms:
dh_fixperms
chmod 755 $(tmp)/usr/share/man/man5/foo.5.gz
diff --git a/t/tests/files-general/desc b/t/tests/files-general/desc
index 54caba0..732ca23 100644
--- a/t/tests/files-general/desc
+++ b/t/tests/files-general/desc
@@ -16,5 +16,6 @@ Test-For:
package-contains-mime-cache-file
package-contains-mimeinfo.cache-file
package-modifies-ld.so-search-path
+ star-file
stray-directory-in-manpage-directory
windows-devel-file-in-package
diff --git a/t/tests/files-general/tags b/t/tests/files-general/tags
index 55d3edd..a05c103 100644
--- a/t/tests/files-general/tags
+++ b/t/tests/files-general/tags
@@ -7,6 +7,7 @@ E: files-general: package-contains-info-dir-file usr/share/info/dir.gz
E: files-general: package-contains-mime-cache-file usr/share/mime/types
E: files-general: package-contains-mimeinfo.cache-file usr/share/applications/mimeinfo.cache
E: files-general: package-modifies-ld.so-search-path etc/ld.so.conf.d/lintian-lib.conf
+E: files-general: star-file usr/share/foo/*
E: files-general: stray-directory-in-manpage-directory usr/share/man/man1/random/
I: files-general: duplicated-compressed-file usr/share/doc/lintian/lintian-16x16.png.gz
I: files-general: package-contains-empty-directory usr/share/man/man1/random/
--
Debian package checker
Reply to: