[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1029356: marked as done (Thinkpad AMD: amd_pmc module is required for correct s0ix (Windows mode) suspend)

Your message dated Tue, 24 Jan 2023 08:03:23 +0100
with message-id <5642177.DvuYhMxLoT@turnagra>
and subject line Re: Bug#1029356: Thinkpad AMD: amd_pmc module is required for correct s0ix (Windows mode) suspend
has caused the Debian Bug report #1029356,
regarding Thinkpad AMD: amd_pmc module is required for correct s0ix (Windows mode) suspend
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1029356: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1029356
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: linux-image-6.1.0-1-amd64
Version: 6.1.4-1
Severity: important

Hello there,

this is a regression from 6.0.0 too; after post-suspend wakeup, my
plasma wayland session stays frozen; the two DisplayPort screens light
up, backgrounds are shown, but the mouse doesn't move, nothing works.

I'm reportbug'ging this from a SysRQ-R, Ctrl-Alt-F2 text tty.

>From cursory dmesg reading, it seems amdgpu has an "IB test failed"
_before_ kernel suspend.

This is on 6.1.4-1a~test, patched against the "2nd DisplayPort doesn't
light up", so feel free to close the bug; I'll test if I get the same
symptoms on an unpatched kernel anyway :-)

Best,

OdyX


-- System Information:
Debian Release: bookworm/sid
  APT prefers buildd-unstable
  APT policy: (500, 'buildd-unstable'), (500, 'unstable'), (500, 'testing'), (1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.1.0-1-amd64 (SMP w/16 CPU threads; PREEMPT)
Kernel taint flags: TAINT_UNSIGNED_MODULE
Locale: LANG=fr_CH.UTF-8, LC_CTYPE=fr_CH.UTF-8 (charmap=UTF-8), LANGUAGE=fr_CH:fr
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages linux-image-6.1.0-1-amd64 depends on:
ii  initramfs-tools [linux-initramfs-tool]  0.142
ii  kmod                                    30+20221128-1
ii  linux-base                              4.9

Versions of packages linux-image-6.1.0-1-amd64 recommends:
ii  apparmor             3.0.8-1
ii  firmware-linux-free  20200122-1

Versions of packages linux-image-6.1.0-1-amd64 suggests:
pn  debian-kernel-handbook  <none>
ii  extlinux                3:6.04~git20190206.bf6db5b4+dfsg1-3+b1
ii  grub-efi-amd64          2.06-7
pn  linux-doc-6.1           <none>

--- End Message ---
--- Begin Message --- 
Version: 6.1.7-2

Hello there,

Le lundi, 23 janvier 2023, 22.09:22 h CET Salvatore Bonaccorso a écrit :
> (Adding Mario to CC, I guess he is fine with it, given as well
> involved in Debian).
> 
> On Sat, Jan 21, 2023 at 05:54:26PM +0100, Didier 'OdyX' Raboud wrote:
> > Control: tags -1 +patch -help
> > Control: clone -1 -2
> > Control: retitle -2 Thinkpad AMD: amd_pmc module is required for correct
> > s0ix (Windows mode) suspend Control: severity -2 important
> > 
> > Hello there,
> > 
> > My understanding is that there are two distinct bugs here; hereby
> > splitting to make this clearer.
> 
> The answer here is probably "maybe".
> 
> > * Original bug, as retitled by Salvatore; S3 suspend is broken on some AMD
> > 
> >   Ryzens. This is fixed by this patch queue, also attached.
> > 
> > https://gitlab.freedesktop.org/superm1/linux/-/commits/mlimonci/rhbz-21620
> > 13-gitlab-2357-v4/> 
> >   In the BIOS, "S3" is "Linux mode" for suspend.
> 
> This is one clear bug, which has now patches submitted upstream for
> review, hopefully for inclusion and then tickle in in 6.1.y.
> 
> > * While investigating this; it turns out modern kernels can also suspend
> >   on s0ix "Windows mode", but this _requires_ the `amd_pmc` module, which
> >   is not loaded automatically, but it really should. This doesn't look
> >   like an upstream bug, but rather a Debian one.
> >   
> >   As this only shows on Laptops with a "Windows mode" BIOS configuration
> >   (in a box that also shows "Linux mode"), I think it's reasonable to see
> >   this as a bug of only "important" level (even though not resuming from
> >   suspend is _bad_).
> >   
> >   I don't think we have seen a patch to fix this one yet though.
> 
> I asked explicitly again here upstream, but I think there might be a
> missunderstanding of each other's side. I asked upstream what can help
> identify why the module is not autoloading, in the thread
> https://lore.kernel.org/lkml/Y81Ja5Y%2FtgPXk5FA@eldamar.lan/#t .
> Unfortunately the replies from Mario are not archived. But his final
> 
> reply was:
> > Salvatore,
> > 
> > I don't think we have a bug here. The reporters said it's working
> > for s0ix.
> > 
> > It will only load by default when the system is set to Modern
> > Standby/s2idle mode in BIOS. On Lenovo systems they call this
> > "Windows" sleep mode for some systems.
> 
> Didier, in my undestanding of your comments on upstream issue, you did
> that actually, correct? I.e. setting to Modern Standby/s2idle mode in
> BIOS, but amd_pmc was still *not* autoloading?

Right. I probably got confused during testing; or it was not the case in a 
previous version. I just rebooted in my 6.1.7-2 (with two patches) with 
amd_pmc commented in its /etc/modules-load.d/* file, and indeed, it's loaded 
now.

Hereby closing then; thanks for your patience!

Cheers,

    OdyX

Attachment: signature.asc
Description: This is a digitally signed message part.


--- End Message ---
Reply to: