[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: darcs: haskell-blogliterately: Initial Check-In



Hi Dimitry,

doing a review of your packaging now:

Am Montag, den 29.12.2014, 08:48 +0000 schrieb Dmitry Bogatov:
> diff -rN -u old-haskell-blogliterately/blogliterately.install new-haskell-blogliterately/blogliterately.install
> --- old-haskell-blogliterately/blogliterately.install	1970-01-01 00:00:00.000000000 +0000
> +++ new-haskell-blogliterately/blogliterately.install	2014-12-29 08:48:23.264095029 +0000
> @@ -0,0 +1 @@
> +dist-ghc/build/BlogLiterately/BlogLiterately usr/bin

there is a better because more declarative way to install haskell
binaries: Replace this by a file
"debian/blogliterately.haskell-binaries" with the contents
"BlogLiterately"


> diff -rN -u old-haskell-blogliterately/BlogLiterately.md new-haskell-blogliterately/BlogLiterately.md
> --- old-haskell-blogliterately/BlogLiterately.md	1970-01-01 00:00:00.000000000 +0000
> +++ new-haskell-blogliterately/BlogLiterately.md	2014-12-29 08:48:23.264095029 +0000
> @@ -0,0 +1,86 @@
> +% BLOGLITERATELY(1) BlogLiteerately Manual

typo:                          ^

> +X-Description: Tool for posting articles to blogs (internals)
> + This package provides development internals of BlogLiterately tool,
> + allowing you write blog posts in Markdown format, then use it to do
> + syntax highlighting, format ghci sessions, and upload to any blog
> + supporting the metaWeblog API (such as Wordpress)
> + .
> + This package is made avaliliable to make customization possible,
typo:                    ^
> + in particular, to create your own executable which adds extra custom
> + transformations.

How common is that? If hardy anyone will use the libraries, and most
just the binary, maybe we should provide only that.
> + .
> + End-user is probably interested in `blogliterately' package, which
> + provides ready to use executable.
            ^-- insert "a" 


> +Package: blogliterately
> +Architecture: any
> +Section: misc

Better web?

> diff -rN -u old-haskell-blogliterately/rules new-haskell-blogliterately/rules
> --- old-haskell-blogliterately/rules	1970-01-01 00:00:00.000000000 +0000
> +++ new-haskell-blogliterately/rules	2014-12-29 08:48:23.280095039 +0000
> @@ -0,0 +1,12 @@
> +#!/usr/bin/make -f
> +
> +DEB_CABAL_PACKAGE = blogliterately
> +DEB_DEFAULT_COMPILER = ghc
> +
> +include /usr/share/cdbs/1/rules/debhelper.mk
> +include /usr/share/cdbs/1/class/hlibrary.mk
> +
> +build/haskell-blogliterately-utils:: build-ghc-stamp

This should be "build/blogliterately"

> +
> +install/blogliterately::
> +	pandoc -st man debian/BlogLiterately.md -o debian/BlogLiterately.1

It would be more a idiomatic makefile to write

debian/BlogLiterately.1: debian/BlogLiterately.md
    pandoc -st man debian/BlogLiterately.md -o debian/BlogLiterately.1

install/blogliterately:: debian/BlogLiterately.1



Greetings,
Joachim
-- 
Joachim "nomeata" Breitner
Debian Developer
  nomeata@debian.org | ICQ# 74513189 | GPG-Keyid: F0FBF51F
  JID: nomeata@joachim-breitner.de | http://people.debian.org/~nomeata

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: