[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#878322: marked as done (ax25-tools: Various tools segfault when run)

Your message dated Tue, 31 Oct 2017 00:18:58 +0000
with message-id <E1e9KGg-000EyA-NY@fasolo.debian.org>
and subject line Bug#878322: fixed in ax25-tools 0.0.10-rc4-2
has caused the Debian Bug report #878322,
regarding ax25-tools: Various tools segfault when run
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
878322: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=878322
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: ax25-tools
Version: 0.0.10-rc4-1
Severity: serious
Tags: upstream patch

Hi,
As discussed on IRC, various tools in ax25-tools segfault when run. For
example:

> $ /usr/sbin/kissnetd -p 5
> kissnetd V 1.5 by Frederic RIBLE F1OAT - ATEPRA FPAC/Linux Project
> [1]    22672 segmentation fault  /usr/sbin/kissnetd -p 5

This because the prototype for ptsname is not available, so it
implicitly returns an int, which gets cast back to a pointer, truncating
the return value. The attached patch fixes this by defining the relevant
feature macros to their required values so ptsname's prototype is
declared.

Regards,
James

--- a/kiss/kissattach.c
+++ b/kiss/kissattach.c
@@ -1,5 +1,6 @@
+#define _DEFAULT_SOURCE
+#define _XOPEN_SOURCE 500
 #include <stdio.h>
-#define __USE_XOPEN
 #include <stdlib.h>
 #include <string.h>
 #include <unistd.h>
--- a/kiss/kissnetd.c
+++ b/kiss/kissnetd.c
@@ -9,8 +9,9 @@
  * F1OAT 960804 - Frederic RIBLE
  */
  
+#define _DEFAULT_SOURCE
+#define _XOPEN_SOURCE 500
 #include <stdio.h>
-#define __USE_XOPEN
 #include <stdlib.h>
 #include <sys/time.h>
 #include <sys/types.h>
--- a/kiss/mkiss.c
+++ b/kiss/mkiss.c
@@ -37,8 +37,9 @@
  * 1.08 xx/xx/99 Tom Mazouch - Adjustable poll interval
  */
 
+#define _DEFAULT_SOURCE
+#define _XOPEN_SOURCE 500
 #include <stdio.h>
-#define __USE_XOPEN
 #include <string.h>
 #include <errno.h>
 #include <stdlib.h>
--- a/kiss/net2kiss.c
+++ b/kiss/net2kiss.c
@@ -30,8 +30,9 @@
 
 /*****************************************************************************/
 
+#define _DEFAULT_SOURCE
+#define _XOPEN_SOURCE 500
 #include <stdio.h>
-#define __USE_XOPEN
 #include <stdlib.h>
 #include <sys/types.h>
 #include <sys/time.h>
--- a/6pack/m6pack.c
+++ b/6pack/m6pack.c
@@ -33,8 +33,9 @@
  *********************************************************************
  */
 
+#define _DEFAULT_SOURCE
+#define _XOPEN_SOURCE 500
 #include <stdio.h>
-#define __USE_XOPEN
 #include <string.h>
 #include <errno.h>
 #include <stdlib.h>

--- End Message ---
--- Begin Message --- 
Source: ax25-tools
Source-Version: 0.0.10-rc4-2

We believe that the bug you reported is fixed in the latest version of
ax25-tools, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 878322@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dave Hibberd <d@vehibberd.com> (supplier of updated ax25-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 30 Oct 2017 23:30:38 +0000
Source: ax25-tools
Binary: ax25-tools ax25-xtools
Architecture: source amd64
Version: 0.0.10-rc4-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Hamradio Maintainers <debian-hams@lists.debian.org>
Changed-By: Dave Hibberd <d@vehibberd.com>
Description:
 ax25-tools - tools for AX.25 interface configuration
 ax25-xtools - tools for AX.25 interface configuration -- X11-based
Closes: 878322
Changes:
 ax25-tools (0.0.10-rc4-2) unstable; urgency=medium
 .
   * Add patch 02-ptsname-prototype.patch to fix segfault at runtime
     - Closes: #878322
   * Adds standards 4.1.1 and dh compat 10
     - Updated debian/control
     - Updated debian/compat
   * Updated hardening
     - Cleaned up debian/rules
     - New patch 03-string_literal.patch
       - Clears -Werrors errors due to passing string literals
   * Updated 01-spelling-fixes.patch to account for other spelling errors
Checksums-Sha1:
 5c6044919b6574504c05d959cc360a7c90d2ec15 1928 ax25-tools_0.0.10-rc4-2.dsc
 5e27fd1871446cfcf9fb5cdcddbedcf8424a3eb0 8728 ax25-tools_0.0.10-rc4-2.debian.tar.xz
 d943f66d5075d660ac804512fce7f6fa2d9db2ad 368432 ax25-tools-dbgsym_0.0.10-rc4-2_amd64.deb
 fa33ceebc70fe35199647d904c49c436df502d02 9304 ax25-tools_0.0.10-rc4-2_amd64.buildinfo
 9f8f649c7300eef412df52616f20820d45e7270e 187716 ax25-tools_0.0.10-rc4-2_amd64.deb
 8e1e3c0b893a943a8f6bf666781c783d709812f1 164888 ax25-xtools-dbgsym_0.0.10-rc4-2_amd64.deb
 b8248c3cf63446d9f9d9963c9e6c879369426770 33164 ax25-xtools_0.0.10-rc4-2_amd64.deb
Checksums-Sha256:
 aa6539434275fb60b6d21b79f31d5cba716659769fb982835de57e92d23f8367 1928 ax25-tools_0.0.10-rc4-2.dsc
 a06661fbf530dcebaf029cabc700d95a292948ba82f97701b56702e1e5e13b5c 8728 ax25-tools_0.0.10-rc4-2.debian.tar.xz
 21ff9702de06b154ccc16f301c2e0f89122beeb59dbdaf542d05485e4a224cf9 368432 ax25-tools-dbgsym_0.0.10-rc4-2_amd64.deb
 b58bef01db83268396b64f669737cbeb42136f06cd3f0e8f16cf7866b8cca6bb 9304 ax25-tools_0.0.10-rc4-2_amd64.buildinfo
 cf1db1a9f22db5c23a32908749365605c896bffd065d27a63e9204d3bea08171 187716 ax25-tools_0.0.10-rc4-2_amd64.deb
 9d5b0b138ad5e76681090537252f3730aed53099d877305d6631f58f4760025a 164888 ax25-xtools-dbgsym_0.0.10-rc4-2_amd64.deb
 45b48299a31509fc11f5e63c97f144c6c71382bcb90051d355b2537518e4381e 33164 ax25-xtools_0.0.10-rc4-2_amd64.deb
Files:
 bf6571c1ced62c1db6648f927df230fe 1928 hamradio optional ax25-tools_0.0.10-rc4-2.dsc
 1fd6f5ecc77868f2b4dfc69d6b65c5a6 8728 hamradio optional ax25-tools_0.0.10-rc4-2.debian.tar.xz
 57e676b9aeac935cd5ae85031fd68f35 368432 debug optional ax25-tools-dbgsym_0.0.10-rc4-2_amd64.deb
 dbbd8a471d36f641eda2a797eb55e8ca 9304 hamradio optional ax25-tools_0.0.10-rc4-2_amd64.buildinfo
 d545faad530ab5c3da8c6664de2dc203 187716 hamradio optional ax25-tools_0.0.10-rc4-2_amd64.deb
 f95f8ec42e56e5f96602369704ed0268 164888 debug optional ax25-xtools-dbgsym_0.0.10-rc4-2_amd64.deb
 6dcaf39175f07e03535c4cb2f7911096 33164 hamradio optional ax25-xtools_0.0.10-rc4-2_amd64.deb

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEXk9UUZPolpyKWbgKA6H7ehkEdxsFAln3tz0ACgkQA6H7ehkE
dxu9UwgApDMZo2r3UTnfdtCzu7De5QSOuxC3/+TdDzTA54+CZpr1ObUDwwVG9aNM
f1S8jbzZFx9AVDagSYZ05ca6GNrgfQK9aBxEb3avRiZGs/6pIQldTsTXWxSgDTZ2
8XA0RkqoIF54tZJIna1/RtPbMkzcpFw0Pgqpm53QCFDF3kLdsoXmaiGMVigtYDZL
aeJuSsSq0uRQPkOCN7kUFCkRMjkEK9ue6oUa4OtuO325rZqe6vlXPdscODN4t8d1
vjQ94avHK6akeC1HlqdBwK539vHBUCjDJOkFYTBJfQBavPOGa89B+MpBN+qY+J5u
bBQ1kdo8i/iOpmrXpCBzmNt56VyI+A==
=hHVS
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: