[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Update of golang-github-gdamore-cell to 2.*



Cyril,

First of all I am so sorry for not letting you know! I foolishly
assumed that since we were uploading a new package it would not create
these issues - lesson learned. :D  Second, I looked at your branch and
it looks awesome. That's a clever fix for the problem - I checked a
few similar packages and saw the breaks/replaces so I went with it,
but this is significantly more elegant anyway! Feel free to merge and
upload if you'd like or I am happy to as well, just let me know.

Thanks,

Stephen

On Tue, Feb 2, 2021 at 8:28 PM Cyril Brulebois <cyril@debamax.com> wrote:
>
> Cyril Brulebois <cyril@debamax.com> (2021-02-03):
> > It looks to me this would be better [debian/control]:
> >
> >     -XS-Go-Import-Path: github.com/gdamore/tcell
> >     +XS-Go-Import-Path: github.com/gdamore/tcell/v2
> >
> > After all, that's what getting declared through go.mod, and what callers
> > are expecting to embed in theirs, isn't it?
> >
> > Of course, it doesn't help that dh-make-golang doesn't know about this,
> > and that there aren't any well-established practice, apparently, see the
> > mini-thread (3 mails total) here:
> >
> >     https://lists.debian.org/debian-go/2020/12/msg00044.html
>
> You'll find a cyril/master branch in the repository implementing this
> change and preparing the revert of the Breaks/Replaces addition. It
> was build-tested in a development environment as well as under
> cowbuilder.
>
> Stashing the resulting binary in a local repository, I've tested this
> successfully:
>  - rebuilding reverse dependencies spotted by ratt, using sbuild:
>    golang-github-rivo-tview_0.0~git20210122.745e4ce-1 is happy.
>  - co-installing golang-github-gdamore-tcell.v2-dev_2.1.0-5_all.deb and
>    golang-github-gdamore-tcell-dev_1.3.0-2_all.deb during a crowdsec
>    build in a non-clean, schroot-based unstable environment, where I'm
>    doing my Go-related development.
>  - ditto in a cowbuilder environment.
>
> Feel free to let me know if you have any questions/objections to this
> proposed approach, so that I can iterate with you, or proceed with an
> upload as soon as possible.
>
>
> Thanks!
> --
> Cyril Brulebois -- Debian Consultant @ DEBAMAX -- https://debamax.com/


Reply to: