--- Begin Message ---
Package: gcc-13
Version: 13.2.0-7
The gcc-ice-dump.diff patch causes the GCC driver to test for the
DEB_BUILD_OPTIONS environment variable and generate extra debug output
when an ICE occurs, for instance. This is an interesting feature,
while building other packages, but not while building GCC itself IMHO.
Dejagnu would consider that as excess errors.
I suggest to add variables to DEB_BUILD_OPTIONS to disable that
feature, and use them accordingly for the gcc-13 package itself.
Patches attached. Regression tested on x86_64-linux-gnu for
--enable-languages=c,c++ on bullseye and bookworm. Not essential, but
interesting to have for testing / trixie.
gcc-ice=norepro
FAIL: gcc.dg/plugin/crash-test-ice-sarif.c
-fplugin=./crash_test_plugin.so (test for excess errors)
FAIL: gcc.dg/plugin/crash-test-ice-stderr.c
-fplugin=./crash_test_plugin.so (test for excess errors)
FAIL: gcc.dg/plugin/crash-test-write-though-null-sarif.c
-fplugin=./crash_test_plugin.so (test for excess errors)
FAIL: gcc.dg/plugin/crash-test-write-though-null-stderr.c
-fplugin=./crash_test_plugin.so (test for excess errors)
gcc-ice=nodump
FAIL: c-c++-common/goacc/kernels-decompose-pr100400-1-3.c
-std=c++14 (test for excess errors)
FAIL: c-c++-common/goacc/kernels-decompose-pr100400-1-3.c
-std=c++17 (test for excess errors)
FAIL: c-c++-common/goacc/kernels-decompose-pr100400-1-3.c
-std=c++20 (test for excess errors)
FAIL: c-c++-common/goacc/kernels-decompose-pr100400-1-3.c
-std=c++98 (test for excess errors)
FAIL: c-c++-common/goacc/kernels-decompose-pr100400-1-4.c
-std=c++14 (test for excess errors)
FAIL: c-c++-common/goacc/kernels-decompose-pr100400-1-4.c
-std=c++17 (test for excess errors)
FAIL: c-c++-common/goacc/kernels-decompose-pr100400-1-4.c
-std=c++20 (test for excess errors)
FAIL: c-c++-common/goacc/kernels-decompose-pr100400-1-4.c
-std=c++98 (test for excess errors)
FAIL: g++.dg/cpp0x/vt-88982.C -std=c++14 (test for excess errors)
FAIL: g++.dg/cpp0x/vt-88982.C -std=c++17 (test for excess errors)
FAIL: g++.dg/cpp0x/vt-88982.C -std=c++20 (test for excess errors)
FAIL: g++.dg/cpp1y/auto-fn61.C -std=c++14 (test for excess errors)
FAIL: g++.dg/cpp1y/auto-fn61.C -std=c++17 (test for excess errors)
FAIL: g++.dg/cpp1y/auto-fn61.C -std=c++20 (test for excess errors)
From c046ddaa942288ba15816a94d697b0f45a702424 Mon Sep 17 00:00:00 2001
From: Gwenole Beauchesne <gb.devel@gmail.com>
Date: Sat, 2 Dec 2023 08:02:10 +0100
Subject: [PATCH 2/2] gcc: no ICE repro if DEB_BUILD_OPTIONS contains
gcc-ice=norepro.
Don't try to reproduce the ICE if DEB_BUILD_OPTIONS environment variable
contains gcc-ice=norepro. This fixes the following testsuite failures:
FAIL: gcc.dg/plugin/crash-test-ice-sarif.c -fplugin=./crash_test_plugin.so (test for excess errors)
FAIL: gcc.dg/plugin/crash-test-ice-stderr.c -fplugin=./crash_test_plugin.so (test for excess errors)
FAIL: gcc.dg/plugin/crash-test-write-though-null-sarif.c -fplugin=./crash_test_plugin.so (test for excess errors)
FAIL: gcc.dg/plugin/crash-test-write-though-null-stderr.c -fplugin=./crash_test_plugin.so (test for excess errors)
Signed-off-by: Gwenole Beauchesne <gb.devel@gmail.com>
---
gcc/gcc.cc | 22 ++++++++++++++++++----
1 file changed, 18 insertions(+), 4 deletions(-)
diff --git a/gcc/gcc.cc b/gcc/gcc.cc
index 28164c83c8f..691cf81007b 100644
--- a/gcc/gcc.cc
+++ b/gcc/gcc.cc
@@ -3108,6 +3108,21 @@ access_check (const char *name, int mode)
return access (name, mode);
}
+/* Check whether DEB_BUILD_OPTIONS environment variable is set, and
+ that it does not contain the specified exclusion keyword. */
+
+static bool
+has_deb_build_options (const char *exclude_str = nullptr)
+{
+ const char *const deb_build_options = env.get ("DEB_BUILD_OPTIONS");
+ if (!deb_build_options)
+ return false;
+
+ if (exclude_str && strstr (deb_build_options, exclude_str))
+ return false;
+ return true;
+}
+
/* Callback for find_a_file. Appends the file name to the directory
path. If the resulting file exists in the right mode, return the
full pathname to the file. */
@@ -3634,7 +3649,8 @@ execute (void)
/* For ICEs in cc1, cc1obj, cc1plus see if it is
reproducible or not. */
const char *p;
- const char *deb_build_options = env.get("DEB_BUILD_OPTIONS");
+ const bool deb_build_options
+ = has_deb_build_options ("gcc-ice=norepro");
if ((flag_report_bug || deb_build_options)
&& WEXITSTATUS (status) == ICE_EXIT_CODE
&& i == 0
@@ -7895,9 +7911,7 @@ do_report_bug (const char **new_argv, const int nargs,
if (status == ATTEMPT_STATUS_SUCCESS)
{
- const char *deb_build_options = env.get("DEB_BUILD_OPTIONS");
- const bool gcc_dump = deb_build_options &&
- !strstr (deb_build_options, "gcc-ice=nodump");
+ const bool gcc_dump = has_deb_build_options ("gcc-ice=nodump");
const bool gcc_apport = !env.get ("GCC_NOAPPORT") &&
!access ("/usr/share/apport/gcc_ice_hook", R_OK | X_OK);
--
2.39.2
From a2fa3b638c3e1acd58b16eb7079d8402e9dec958 Mon Sep 17 00:00:00 2001
From: Gwenole Beauchesne <gb.devel@gmail.com>
Date: Fri, 1 Dec 2023 22:01:48 +0100
Subject: [PATCH 1/2] gcc: no GCC dump if DEB_BUILD_OPTIONS contains
gcc-ice=nodump.
Don't output GCC dump if the DEB_BUILD_OPTIONS environment variable
contains gcc-ice=nodump. This allows for the testsuite to run XFAIL
tests gracefully for dg-ice.
FAIL: c-c++-common/goacc/kernels-decompose-pr100400-1-3.c -std=c++14 (test for excess errors)
FAIL: c-c++-common/goacc/kernels-decompose-pr100400-1-3.c -std=c++17 (test for excess errors)
FAIL: c-c++-common/goacc/kernels-decompose-pr100400-1-3.c -std=c++20 (test for excess errors)
FAIL: c-c++-common/goacc/kernels-decompose-pr100400-1-3.c -std=c++98 (test for excess errors)
FAIL: c-c++-common/goacc/kernels-decompose-pr100400-1-4.c -std=c++14 (test for excess errors)
FAIL: c-c++-common/goacc/kernels-decompose-pr100400-1-4.c -std=c++17 (test for excess errors)
FAIL: c-c++-common/goacc/kernels-decompose-pr100400-1-4.c -std=c++20 (test for excess errors)
FAIL: c-c++-common/goacc/kernels-decompose-pr100400-1-4.c -std=c++98 (test for excess errors)
FAIL: g++.dg/cpp0x/vt-88982.C -std=c++14 (test for excess errors)
FAIL: g++.dg/cpp0x/vt-88982.C -std=c++17 (test for excess errors)
FAIL: g++.dg/cpp0x/vt-88982.C -std=c++20 (test for excess errors)
FAIL: g++.dg/cpp1y/auto-fn61.C -std=c++14 (test for excess errors)
FAIL: g++.dg/cpp1y/auto-fn61.C -std=c++17 (test for excess errors)
FAIL: g++.dg/cpp1y/auto-fn61.C -std=c++20 (test for excess errors)
Signed-off-by: Gwenole Beauchesne <gb.devel@gmail.com>
---
gcc/gcc.cc | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/gcc/gcc.cc b/gcc/gcc.cc
index 4345a7ec3d6..28164c83c8f 100644
--- a/gcc/gcc.cc
+++ b/gcc/gcc.cc
@@ -7896,10 +7896,15 @@ do_report_bug (const char **new_argv, const int nargs,
if (status == ATTEMPT_STATUS_SUCCESS)
{
const char *deb_build_options = env.get("DEB_BUILD_OPTIONS");
+ const bool gcc_dump = deb_build_options &&
+ !strstr (deb_build_options, "gcc-ice=nodump");
+ const bool gcc_apport = !env.get ("GCC_NOAPPORT") &&
+ !access ("/usr/share/apport/gcc_ice_hook", R_OK | X_OK);
- fnotice (stderr, "Preprocessed source stored into %s file,"
+ if (gcc_dump || gcc_apport)
+ fnotice (stderr, "Preprocessed source stored into %s file,"
" please attach this to your bugreport.\n", *out_file);
- if (deb_build_options)
+ if (gcc_dump)
{
char *cmd = XNEWVEC (char, 50 + strlen (*out_file));
@@ -7912,8 +7917,7 @@ do_report_bug (const char **new_argv, const int nargs,
fflush(stderr);
free(cmd);
}
- if (!env.get ("GCC_NOAPPORT")
- && !access ("/usr/share/apport/gcc_ice_hook", R_OK | X_OK))
+ if (gcc_apport)
{
char *cmd = XNEWVEC (char, 50 + strlen (*out_file)
+ strlen (new_argv[0]));
--
2.39.2
--- End Message ---
--- Begin Message ---
Source: gcc-13
Source-Version: 13.2.0-9
Done: Matthias Klose <doko@debian.org>
We believe that the bug you reported is fixed in the latest version of
gcc-13, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 1057635@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Matthias Klose <doko@debian.org> (supplier of updated gcc-13 package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Thu, 14 Dec 2023 19:55:12 +0100
Source: gcc-13
Architecture: source
Version: 13.2.0-9
Distribution: unstable
Urgency: medium
Maintainer: Debian GCC Maintainers <debian-gcc@lists.debian.org>
Changed-By: Matthias Klose <doko@debian.org>
Closes: 1057433 1057635
Changes:
gcc-13 (13.2.0-9) unstable; urgency=medium
.
* Update to git 20231214 from the gcc-13 branch.
- Fix PR target/112891 (x86), PR target/112845 (x86),
PR target/112837 (x86), PR target/112816 (x86), PR target/111408 (x86),
PR tree-optimization/111967, PR c/112339, PR c++/110106, PR c++/112410,
PR c++/109876, PR c++/112795, PR fortran/93762, PR fortran/100651,
PR libgomp/111413, PR libstdc++/111826, PR libstdc++/111948,
PR libstdc++/112480, PR libstdc++/112473, PR libstdc++/112832,
PR libstdc++/110133.
* Backport libiberty: Use x86 HW optimized sha1 and followup patch,
needed for the combined build.
* Use DEB_BUILD_OPTIONS='... gcc-ice=nodump' for turning off dumping
the preprocessed source to stdout. Closes: #1057635.
* Set DEB_BUILD_OPTIONS='... gcc-ice=nodump' when running the testsuite.
* Default to pie on loong64. Closes: #1057433.
* For Ubuntu 24.04 LTS and later, switch _FORTIFY_SOURCE to 3 by default
instead of 2 when optimization is enabled. LP: #2012440.
Checksums-Sha1:
f2b2a5c4d72bf678c8bc2a787504c9127c27b73b 27277 gcc-13_13.2.0-9.dsc
92b657e69fef8a7b7e3cba4b857ef0998b796841 1745200 gcc-13_13.2.0-9.debian.tar.xz
13904e4e43f619bb2c2942ec59640167e232b7da 8933 gcc-13_13.2.0-9_source.buildinfo
Checksums-Sha256:
289749f4490b95cebca036359f8735b85d8119e9a8d0b2a89c31a6db8141ccf4 27277 gcc-13_13.2.0-9.dsc
aecc4e79ae7f6bff1982f0fb9dc3f925e6929d37f516566a5964029c00f28b6c 1745200 gcc-13_13.2.0-9.debian.tar.xz
80ad8703e4bed187a945f618a4eb26f1ad45131f9995adafa7d9baa780798e2f 8933 gcc-13_13.2.0-9_source.buildinfo
Files:
18a47d581d1c292411d01449e84bedfd 27277 devel optional gcc-13_13.2.0-9.dsc
1b274a376be8fc3e74ecedd9f9f40a70 1745200 devel optional gcc-13_13.2.0-9.debian.tar.xz
f131ed362e35e8694490d64d688b3793 8933 devel optional gcc-13_13.2.0-9_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJEBAEBCgAuFiEE1WVxuIqLuvFAv2PWvX6qYHePpvUFAmV7UFIQHGRva29AZGVi
aWFuLm9yZwAKCRC9fqpgd4+m9a/CD/9w7WUwuj3/BgY3CMDUYdQJY8qwekHwHw5d
KJwOLUfLVj5jJGA7qix4WMFFuLF5Om5jzJicWZg0+SRqQNjDrldAQsVNazezQ7LG
H+sJTd2yL+3L6o4iumUidlecMxS+NA6KOZbz/+S6v/zqbvQY3AZ8/1ZDZfQ0Y+fq
/halvroDQ6euMtoWFBp8jbJ+7F/tNVDiyXE/XHODUVNLfYZvgQKULSbhgRjqP/ed
QTXUUjuvohvglH1JunhB1MCGHJ5jmO7z9BhatjJ9NRKXlpF8VMPQG23darWhmhbY
5uO1VrxLV7ORl8zucAuQmDiLkkYKSfzS0mH40zXQ5OlvL7UShAEvj/OVolTpGcDe
f+v0d4pjkGFbswJNSjJEcErhlb23jszIN65vWLTZSc97RVWY2/+ydBsNO9IhF8f4
MwOboK9HYwrt0DAa42/Er8qOqNHa3z0hih7Zs4eeAwWACtB0ckkbjHoUKT1ZsI6s
+v+QQ/PFVDjD4Xx58SMaAUDlhDKka+R+A0Priari+JefCTpB9Cu2rOCmRMjjzoEH
v2Gq/y/jNu6SUw9S7aMw+1B86A3/t26Auf/4kdthWtOuJPTMxm5ENTiclFzsuIbF
x8EgQQbfoarZ1XJzyaCL11013MJj3Si5nurobPvsmr6yQSpCofKd5uO+0FFnZ/Ef
pUQ5cFvIxw==
=FYZS
-----END PGP SIGNATURE-----
--- End Message ---