[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[Pkg-fonts-devel] Bug#659603: marked as done (fonts-ocr-a: use dh_installdeb maintscript support)

Your message dated Sat, 01 Feb 2014 13:48:22 +0000
with message-id <E1W9avm-0007oN-AI@franck.debian.org>
and subject line Bug#659603: fixed in fonts-ocr-a 1.0-6
has caused the Debian Bug report #659603,
regarding fonts-ocr-a: use dh_installdeb maintscript support
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
659603: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=659603
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: fonts-ocr-a
Version: 1.0-4
Severity: wishlist
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch precise

Using 'dpkg-maintscript-helper supports rm_conffile' guards introduces
unreliability into upgrades; it means that the conffile is removed or
not depending on whether dpkg happens to be unpacked before fonts-ocr-a.
This seems generally undesirable; it would be better to enforce a single
code path.  (This is academic for Debian because the version of dpkg in
squeeze supported dpkg-maintscript-helper, hence Severity: wishlist;
Ubuntu's last LTS release didn't have a sufficient version of dpkg for
that which is why I care.)

It would be nice to just use dh_installdeb's support for generating
dpkg-maintscript-helper commands, which was introduced in debhelper
8.1.0.  This would remove duplicate code from your maintainer scripts -
in fact, you'd no longer need to have handwritten maintainer scripts at
all.  Here's a patch:

  * Use maintscript support in dh_installdeb rather than writing out
    dpkg-maintscript-helper commands by hand.  We now simply Pre-Depend on a
    new enough version of dpkg rather than using 'dpkg-maintscript-helper
    supports' guards, leading to more predictable behaviour on upgrades.

diff -Nru fonts-ocr-a-1.0/debian/control fonts-ocr-a-1.0/debian/control
--- fonts-ocr-a-1.0/debian/control	2011-10-14 11:47:05.000000000 +0100
+++ fonts-ocr-a-1.0/debian/control	2012-02-12 14:08:51.000000000 +0000
@@ -3,12 +3,13 @@
 Priority: optional
 Maintainer: Debian Fonts Task Force <pkg-fonts-devel@lists.alioth.debian.org>
 Uploaders: Gürkan Sengün <gurkan@phys.ethz.ch>
-Build-Depends: debhelper (>= 8), fontforge
+Build-Depends: debhelper (>= 8.1.0~), fontforge
 Standards-Version: 3.9.2
 Homepage: http://sourceforge.net/projects/ocr-a-font
 
 Package: fonts-ocr-a
 Architecture: all
+Pre-Depends: ${misc:Pre-Depends}
 Depends: ${misc:Depends}
 Replaces: ttf-ocr-a (<< 1.0-3)
 Conflicts: ttf-ocr-a (<< 1.0-3)
diff -Nru fonts-ocr-a-1.0/debian/maintscript fonts-ocr-a-1.0/debian/maintscript
--- fonts-ocr-a-1.0/debian/maintscript	1970-01-01 01:00:00.000000000 +0100
+++ fonts-ocr-a-1.0/debian/maintscript	2012-02-12 14:08:21.000000000 +0000
@@ -0,0 +1 @@
+rm_conffile /etc/defoma/hints/ttf-ocr-a.hints 1.0-3
diff -Nru fonts-ocr-a-1.0/debian/postinst fonts-ocr-a-1.0/debian/postinst
--- fonts-ocr-a-1.0/debian/postinst	2011-07-20 20:30:44.000000000 +0100
+++ fonts-ocr-a-1.0/debian/postinst	1970-01-01 01:00:00.000000000 +0100
@@ -1,9 +0,0 @@
-#!/bin/sh
-set -e
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
-  dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-ocr-a.hints 1.0-3 -- "$@"
-fi
-
-#DEBHELPER#
-
diff -Nru fonts-ocr-a-1.0/debian/postrm fonts-ocr-a-1.0/debian/postrm
--- fonts-ocr-a-1.0/debian/postrm	2011-07-20 20:30:58.000000000 +0100
+++ fonts-ocr-a-1.0/debian/postrm	1970-01-01 01:00:00.000000000 +0100
@@ -1,9 +0,0 @@
-#!/bin/sh
-set -e
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
-  dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-ocr-a.hints 1.0-3 -- "$@"
-fi
-
-#DEBHELPER#
-
diff -Nru fonts-ocr-a-1.0/debian/preinst fonts-ocr-a-1.0/debian/preinst
--- fonts-ocr-a-1.0/debian/preinst	2011-07-20 20:30:54.000000000 +0100
+++ fonts-ocr-a-1.0/debian/preinst	1970-01-01 01:00:00.000000000 +0100
@@ -1,9 +0,0 @@
-#!/bin/sh
-set -e
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
-  dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-ocr-a.hints 1.0-3 -- "$@"
-fi
-
-#DEBHELPER#
-

Thanks,

-- 
Colin Watson                                       [cjwatson@ubuntu.com]

--- End Message ---
--- Begin Message --- 
Source: fonts-ocr-a
Source-Version: 1.0-6

We believe that the bug you reported is fixed in the latest version of
fonts-ocr-a, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 659603@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Hideki Yamane <henrich@debian.org> (supplier of updated fonts-ocr-a package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 01 Feb 2014 22:20:04 +0900
Source: fonts-ocr-a
Binary: fonts-ocr-a
Architecture: source all
Version: 1.0-6
Distribution: unstable
Urgency: medium
Maintainer: Debian Fonts Task Force <pkg-fonts-devel@lists.alioth.debian.org>
Changed-By: Hideki Yamane <henrich@debian.org>
Description: 
 fonts-ocr-a - ANSI font readable by the computers of the 1960s
Closes: 659603
Changes: 
 fonts-ocr-a (1.0-6) unstable; urgency=medium
 .
   * Team upload.
   * use dh_installdeb maintscript support, thanks to Colin Watson
     <cjwatson@ubuntu.com> for the patch (Closes: #659603)
Checksums-Sha1: 
 51b790fc5dd78904612111a3cce0a53babe771a1 1802 fonts-ocr-a_1.0-6.dsc
 e0f55ca0f09ffdad97aa023189930ac219cb425f 2960 fonts-ocr-a_1.0-6.debian.tar.xz
 8ca9c7a00ce5ef4e0d5b1f7168be234ce1043789 41866 fonts-ocr-a_1.0-6_all.deb
Checksums-Sha256: 
 735b133b1773f6318f6f0ad4beeddf371c423f48b5f3893170514617cbb8fb97 1802 fonts-ocr-a_1.0-6.dsc
 635c841fa3608264fe8e55fca8b309248566ade5f030d90f8ad50b4f1204f606 2960 fonts-ocr-a_1.0-6.debian.tar.xz
 fc33c783eb12c808aac8f2c03045b01b8a59e5d35965d6e13d9ba823fb17c86b 41866 fonts-ocr-a_1.0-6_all.deb
Files: 
 acede8aa5666ca98513fecb0038c3a30 1802 fonts optional fonts-ocr-a_1.0-6.dsc
 e28567e208ca3d4adad0e4b3cad42975 2960 fonts optional fonts-ocr-a_1.0-6.debian.tar.xz
 1949aaf6091b0d4b841cbe2ca976ab82 41866 fonts optional fonts-ocr-a_1.0-6_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJS7PjJAAoJEF0yjQgqqrFAjKAP+wV8PBHTtrl0xYgyrWBWkXwe
oqL7vpSR69KA6XdYNOWB9u5tgM1GyWSATdD7osz0Rn06Pkhskyik67x8vpw7Bue3
HruBwsJpSQrGSTw5JKSWx2UB9/nEhvtcwvcsLqnAngM76kcb47Wlx828y9w9yv4i
94z/qoznZoX0GiQ3gkBQ/iQvFUDgLDp6iQphv0/ZL2HHuBr5fGF2aBkLioOBFD1l
DrRJLRjzzopQX6qiW7x842J1SHmJrZCIVF9BEseZfsvtXr6IgaD41JpfvNwahbrS
jGxaXOatnUaYr+JDj/z3Qyj2Vn33r+hUt6jWOD92wuME0WuCFah7nysc64jlKoZL
9jT2GfQ2DUpqVRrO2/WRy4ZN9qT6vWsKEcZSiu0pZrB3Hw9SHzvaGPJM954wjse0
9Y4zr16Ox22UqZy/AbQBbdGe8KJUpr5bZp7d1IdSd5OO1NDTV4vOk73ME1VSU0Pb
oeiRAiAH14F4I+1pdri4m8SLVHgOae0QOLmFP8GIwoNUBS8QzhUyRYUkGRmtWc+t
l0mrLwpppg7ZhH1vsb4bwdqal5KL+hUvNY+MC5QKV3mqF5+gPubQSI7sq1WOIo6f
Sin8rP+nxiNnlEv/mipSI6ZzjbXdAdJ7W2OvR+miWd1kD4knVtcefLBaDFg3HyBW
hvB1MPnafPU7hQqAP+0j
=V4NC
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: