[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[Pkg-fonts-devel] Bug#659552: marked as done (fonts-breip: use dh_installdeb maintscript support)

Your message dated Sat, 01 Feb 2014 11:48:30 +0000
with message-id <E1W9Z3m-0001m4-Gf@franck.debian.org>
and subject line Bug#659552: fixed in fonts-breip 1.0-9
has caused the Debian Bug report #659552,
regarding fonts-breip: use dh_installdeb maintscript support
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
659552: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=659552
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: fonts-breip
Version: 1.0-7
Severity: wishlist
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch precise

Using 'dpkg-maintscript-helper supports rm_conffile' guards introduces
unreliability into upgrades; it means that the conffile is removed or
not depending on whether dpkg happens to be unpacked before fonts-breip.
This seems generally undesirable; it would be better to enforce a single
code path.  (This is academic for Debian because the version of dpkg in
squeeze supported dpkg-maintscript-helper, hence Severity: wishlist;
Ubuntu's last LTS release didn't have a sufficient version of dpkg for
that which is why I care.)

It would be nice to just use dh_installdeb's support for generating
dpkg-maintscript-helper commands, which was introduced in debhelper
8.1.0.  This would remove duplicate code from your maintainer scripts -
in fact, you'd no longer need to have handwritten maintainer scripts at
all.  Here's a patch:

  * Use maintscript support in dh_installdeb rather than writing out
    dpkg-maintscript-helper commands by hand.  We now simply Pre-Depend on a
    new enough version of dpkg rather than using 'dpkg-maintscript-helper
    supports' guards, leading to more predictable behaviour on upgrades.

diff -Nru fonts-breip-1.0/debian/control fonts-breip-1.0/debian/control
--- fonts-breip-1.0/debian/control	2011-07-29 16:48:34.000000000 +0100
+++ fonts-breip-1.0/debian/control	2012-02-12 00:47:48.000000000 +0000
@@ -3,7 +3,7 @@
 Priority: optional
 Maintainer: Debian Fonts Task Force <pkg-fonts-devel@lists.alioth.debian.org>
 Uploaders: Mauro Lizaur <mauro@debian.org>
-Build-Depends: debhelper (>= 8)
+Build-Depends: debhelper (>= 8.1.0~)
 Build-Depends-Indep: fontforge-nox (>= 0.0.20090923) | fontforge (>= 0.0.20090923)  
 Standards-Version: 3.9.2
 Vcs-Svn: svn://svn.debian.org/pkg-fonts/packages/fonts-breip/trunk
@@ -12,6 +12,7 @@
 
 Package: fonts-breip
 Architecture: all
+Pre-Depends: ${misc:Pre-Depends}
 Depends: ${misc:Depends}
 Replaces: ttf-breip (<< 1.0-7)
 Conflicts: ttf-breip (<< 1.0-7)
diff -Nru fonts-breip-1.0/debian/maintscript fonts-breip-1.0/debian/maintscript
--- fonts-breip-1.0/debian/maintscript	1970-01-01 01:00:00.000000000 +0100
+++ fonts-breip-1.0/debian/maintscript	2012-02-12 00:47:18.000000000 +0000
@@ -0,0 +1 @@
+rm_conffile /etc/defoma/hints/ttf-breip.hints 1.0-7
diff -Nru fonts-breip-1.0/debian/postinst fonts-breip-1.0/debian/postinst
--- fonts-breip-1.0/debian/postinst	2011-07-29 15:18:58.000000000 +0100
+++ fonts-breip-1.0/debian/postinst	1970-01-01 01:00:00.000000000 +0100
@@ -1,9 +0,0 @@
-#!/bin/sh
-set -e
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
-  dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-breip.hints 1.0-7 -- "$@"
-fi
-
-#DEBHELPER#
-
diff -Nru fonts-breip-1.0/debian/postrm fonts-breip-1.0/debian/postrm
--- fonts-breip-1.0/debian/postrm	2011-07-29 15:19:30.000000000 +0100
+++ fonts-breip-1.0/debian/postrm	1970-01-01 01:00:00.000000000 +0100
@@ -1,9 +0,0 @@
-#!/bin/sh
-set -e
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
-  dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-breip.hints 1.0-7 -- "$@"
-fi
-
-#DEBHELPER#
-
diff -Nru fonts-breip-1.0/debian/preinst fonts-breip-1.0/debian/preinst
--- fonts-breip-1.0/debian/preinst	2011-07-29 15:18:46.000000000 +0100
+++ fonts-breip-1.0/debian/preinst	1970-01-01 01:00:00.000000000 +0100
@@ -1,9 +0,0 @@
-#!/bin/sh
-set -e
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
-  dpkg-maintscript-helper rm_conffile /etc/defoma/hints/ttf-breip.hints 1.0-7 -- "$@"
-fi
-
-#DEBHELPER#
-

Thanks,

-- 
Colin Watson                                       [cjwatson@ubuntu.com]

--- End Message ---
--- Begin Message --- 
Source: fonts-breip
Source-Version: 1.0-9

We believe that the bug you reported is fixed in the latest version of
fonts-breip, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 659552@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Hideki Yamane <henrich@debian.org> (supplier of updated fonts-breip package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 01 Feb 2014 20:20:28 +0900
Source: fonts-breip
Binary: fonts-breip
Architecture: source all
Version: 1.0-9
Distribution: unstable
Urgency: medium
Maintainer: Debian Fonts Task Force <pkg-fonts-devel@lists.alioth.debian.org>
Changed-By: Hideki Yamane <henrich@debian.org>
Description: 
 fonts-breip - informal handwriting font
Closes: 659552
Changes: 
 fonts-breip (1.0-9) unstable; urgency=medium
 .
   * Team upload.
   * debian/control
     - set "Build-Depends: debhelper (>= 9)
     - set "Standards-Version: 3.9.5"
   * debian/compat
     - set 9
   * use dh_installdeb maintscript support, thanks to Colin Watson
     <cjwatson@ubuntu.com> for the patch (Closes: #659552)
   * remove unnecessary debian/lintian/fonts-breip file
Checksums-Sha1: 
 059d46be2650d6e8d99dabde18e080619e3884fc 2046 fonts-breip_1.0-9.dsc
 fcc5fa6c3232010ff1a40e56dc79e2f2502c789d 4560 fonts-breip_1.0-9.debian.tar.xz
 4d2fdbf30e7b24cdd40bd95b4acfec5ad4eb321a 37100 fonts-breip_1.0-9_all.deb
Checksums-Sha256: 
 eee9c97d3d4e5af89b8377eefb299f2f6ac2477c451632abb41dae0fb0807cd3 2046 fonts-breip_1.0-9.dsc
 3a28b0f505425652404676d8846e89b620096298d655fe6adeddf1314895fa1f 4560 fonts-breip_1.0-9.debian.tar.xz
 b4e2ed63eb8c2fd55bcb73cbbd6b6034e5db37f07bda2ef1a8e3269da4c6fc4d 37100 fonts-breip_1.0-9_all.deb
Files: 
 cc6d19d356ce24ff9cc17c5b998960dd 2046 fonts optional fonts-breip_1.0-9.dsc
 4f9864b06ddb4d2870ad475e79c54f15 4560 fonts optional fonts-breip_1.0-9.debian.tar.xz
 74111d421d307f48ec5cf48a90cb6575 37100 fonts optional fonts-breip_1.0-9_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJS7NufAAoJEF0yjQgqqrFANXQP/0FWYoIkfQBHu4Fk6tJaHXBv
IHGWQvkyPSpHc9FWgBygBLjKRMun5bZg0bwEFQ+SEJCGVbxIDCvzNQW+k98RunDX
5x094uy+8bYEWTPh/QS6bgWIjrpgcbS/hj6ocFoGD6DjX7Qmx7QzR9VghaRVlYiG
swnaN8kORVQawnQDpSiPTwUm/aQe9bWlD40o/OW/nZpTPLFoPsQ3v8rsnS3PP5N/
ao0zfwIsntLltbTfaWtXc/aq+8R6jjTEktaKJgMemUmIS1WPT51GIgNtGXVL4v1H
jxc2/J7NKqJSmho0xHa51GlQH2Uyz3zca8lxukzwinhLDBBheQNlNaNIMMGnV7Cw
wysvueDoSXL1xI7hsifqzigLsbz3FjHx3rIroKrrUkPk9ffleEsDdFUTvHB/f4uY
/qCuNFgwwz/gWM74E1qe0vel/TD8ODFt/4cBHL74rS7i32V6ybffB/x/JSvaZjlO
xn4Df/WdLSjpOPSM6OOE18M2+ZwB7/YL7Xktv3wFEOc6EOQ49FN0yHC3qqd4f5lO
QVJmPmsEQl0BoGFdn2pjIWrDoy5mW33CuEJMqcP08lUUi9Ujw2c8fM3kU+LSpqT5
zrCvwwqKSgfuV+pKnuwUxaH68fH6uF0aPKOmND8iGugupqhMNaB67p0OAJZ4wD+d
vA5GmaNyJPcLJUziM9qz
=gyXJ
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: