Bug#1063518: console-setup: setupcon: 1386: Syntax error: Missing '))'

[Philip Hands <phil@hands.com>]

Michael Tokarev <mjt@tls.msk.ru> writes:

> 09.02.2024 16:58, cacin@allfreemail.net
>> Package: console-setup
>> Followup-For: Bug #1063518
>> 
>> Consider making all scripts provided by console-setup
>> shellcheck-clean, there are lots of tiny issues that can turn into
>> big issues under the right conditions.
>
> Please do not do this. Shellcheck is a huge problem and we had large amount
> of bugs due to people trying to apply its suggestions.  It's very difficult
> in many cases to spot why shellcheck is wrong (classic is the suggestion to
> put $var into double quotes "$var" which breaks badly if $var is supposed to
> contain zero or more separate words - this way, even boot scripts has become
> buggy leading to system becoming unbootable).
>
> Shellcheck is a very bad tool.

I think the reality is somewhere between these two positions.

Shellcheck is not particularly helpful for most of D-I because it
doesn't have a shell variant that perfectly matches our busybox sh
build.  That might have just improved, since I notice that a busybox sh
variant has just been merged upstream, so we'll see if that makes things
better.

On the other hand, if I'd been paying attention at the time, the fact
that this change dropped the number of shellcheck reports for setupcon
from 189 to 1 should have rung some alarm bells, but it seems that I've
learnt to ignore the little '!' in my emacs status bar -- I'll have to
keep an eye on that in future.

Cheers, Phil.
-- 
Philip Hands -- https://hands.com/~phil