Hi Roger,
Roger Wesson <rw@nebulousresearch.org> writes:
Aha, that explains it! First question, yes, second question,
no... Build-Depends now includes dh-exec, the package builds, so it's
ready for review now.
The package looks good, in principle ready for upload. Some minor
things:
* The binary is not linked against the shared lib. This is probably
because the executable is built (just) before the shared lib. Maybe
you could change the order here to get the shared lib used?
* It would be useful to create a file debian/upstream/metadata with a
reference, like Chris H. Rycroft, Voro++: A three-dimensional Voronoi
cell library in C++, Chaos 19, 041111 (2009) (see
http://math.lbl.gov/voro++/download/).
The format is described here: https://wiki.debian.org/UpstreamMetadata
and an example is here:
https://sources.debian.net/src/gnuastro/0.2.33-1/debian/upstream/metadata/
* You could consider replacing the "exit()" calls in src/common.hh with
"abort()", maybe discuss that with upstream. abort() has the advantage
that one may get a coredump or a stack trace in gdb in case there are
problems. This could help debugging, if one wants to create own
programs with libvoro++.
Could you have a look there?
Best regards
Ole