Bug#990280: RFS: lg-gpio/0.1.7.0-1 [ITP] -- Control GPIO pins remotely

[Dave Jones <dave@waveform.org.uk>]

Hi Bastian,

Thanks for the comments so far! Just one thing to clear up, I think:

On Tue, Nov 16, 2021 at 02:27:11AM +0100, Bastian Germann wrote:
[snip]
> > > d/watch
> > > =======
> > > debian-watch-file-is-missing
> > >
> > > This is very important when you have several packages to maintain. It keeps track of new releases.
> >
> > Unfortunately in this case, upstream's form of distribution doesn't 
> > work with Debian's uscan tooling. Specifically, they distribute 
> > their various libraries and tools (including lg) as a zip file named 
> > after the project without a version component. The version component 
> > is stored as an empty file within the root of the zip file.
[snip]
> I just checked http://abyz.me.uk/lg/lg.zip against the GitHub 
> releases/tags provided archive. They are not bit-by bit identical but 
> contain the same source. As .zip cannot be used as an orig tarball 
> directly, it is actually preferrable in this case not to get the 
> author-uploaded zip but to use the GitHub tar.gz archive.
>
> You can use one of uscan's versionmangle options to add the .0.0 but 
> in my opinion you can also just go with the GitHub tag version. So, 
> please replace your get-orig-source script by d/watch.

Unfortunately, the Git repo tags only represent a tiny fraction of the 
releases done so far. This should show the set of releases that have 
actually been made:

  $ git clone https://github.com/joan2937/lg
  $ cd lg
  $ for h in $(git rev-list master); do
  > git show $h^{tree} | grep "^v[0-9.]*$"
  > done | uniq
  v0.2.0.0
  v0.1.7.0
  v0.1.6.2
  v0.1.6.1
  v0.1.6.0
  v0.1.5.8
  v0.1.5.7
  v0.1.5.6
  v0.1.5.5
  v0.1.5.4
  v0.1.5.3
  v0.1.5.2
  v0.1.5.1
  v0.1.5.0
  v0.1.4.0
  v0.1.3.0
  v0.1.2.2
  v0.1.2.1
  v0.1.2.0
  v0.1.1.0
  v0.1.0.4
  v0.1.0.3
  v0.1.0.2
  v0.1.0.1
  v0.1.0.0
  v0.0.4.3
  v0.0.4.2
  v0.0.4.1
  v0.0.4.0
  v0.0.3.1
  v0.0.3.0
  v0.0.2.0
  v0.0.1.0

In rather stark contrast to:

  $ git tag
  v0.0
  v0.1
  v0.2

In other words, it would appear the author doesn't create tags for every 
release, just major ones. If that's all Debian would be interested in, I 
can certainly put together a d/watch file but I wonder whether it's 
preferable to have an option that picks up all releases (albeit a 
horribly non-standard one)?

> Actually, you are already claiming in d/copyright that Source is 
> https://github.com/joan2937/lg.

Ah, I was under the mis-apprehension that was a relatively informal 
field that simply pointed at a "useful" source location rather than a 
specific source (the archive location in this case is rather less useful 
than the git repo, given it's only ever the latest version available). 

Happy to adjust this accordingly, but figured I'd wait on your response 
to the point above about missing versions before going ahead.

Thanks,

Dave.