Bug#996592: RFS: workflow/0.9.8-1 [ITP] -- Parallel computing and asynchronous web server engine

To: 996592@bugs.debian.org, LQi254@protonmail.com
Subject: Bug#996592: RFS: workflow/0.9.8-1 [ITP] -- Parallel computing and asynchronous web server engine
From: Bastian Germann <bage@debian.org>
Date: Fri, 12 Nov 2021 20:02:52 +0100
Message-id: <[🔎] e13ba456-9e61-8507-1235-66a6c38cfeea@debian.org>
Reply-to: Bastian Germann <bage@debian.org>, 996592@bugs.debian.org
In-reply-to: <[🔎] eOjoM0SmWe8N47ldpvCBMjj5IvIPnoYtkZKdo_bWUQ4BUP3mbobnEGkAM0FqiqcVM7vdrMVU_P7MN4W6YPfEihZA1YuGxRNe7WLFL6GVICQ=@protonmail.com>
References: <hM4VB9VNewdzjuZeOas44h86irnRPLYke4ymdLqnpSWEqxhEg3B29TDavpQBBwel3oWbYMqFP1-YUCg0cWGr0_p3PPmlE-VVTfUbseNccGo=@protonmail.com> <hM4VB9VNewdzjuZeOas44h86irnRPLYke4ymdLqnpSWEqxhEg3B29TDavpQBBwel3oWbYMqFP1-YUCg0cWGr0_p3PPmlE-VVTfUbseNccGo=@protonmail.com> <hM4VB9VNewdzjuZeOas44h86irnRPLYke4ymdLqnpSWEqxhEg3B29TDavpQBBwel3oWbYMqFP1-YUCg0cWGr0_p3PPmlE-VVTfUbseNccGo=@protonmail.com> <49e2617a-09d5-2ee4-cd02-445fd85e059d@debian.org> <[🔎] eOjoM0SmWe8N47ldpvCBMjj5IvIPnoYtkZKdo_bWUQ4BUP3mbobnEGkAM0FqiqcVM7vdrMVU_P7MN4W6YPfEihZA1YuGxRNe7WLFL6GVICQ=@protonmail.com> <[🔎] eOjoM0SmWe8N47ldpvCBMjj5IvIPnoYtkZKdo_bWUQ4BUP3mbobnEGkAM0FqiqcVM7vdrMVU_P7MN4W6YPfEihZA1YuGxRNe7WLFL6GVICQ=@protonmail.com> <hM4VB9VNewdzjuZeOas44h86irnRPLYke4ymdLqnpSWEqxhEg3B29TDavpQBBwel3oWbYMqFP1-YUCg0cWGr0_p3PPmlE-VVTfUbseNccGo=@protonmail.com>

Hi Lance,

The filenamemangle in the debian/watch file is not correct. Please test it with uscan.

Please consider relicensing debian/* or at least debian/patches/* to the same license as upstream(Apache 2). The problem with the debian/* license being more restrictive than upstream is that yourpatches cannot be used by upstream and you might exclude possible reverse dependencies from usingthe Debian package.


You reference the non-existing https://salsa.debian.org/debian/workflow.
If you want to maintain your package there, I can create that repository for you on sponsoring.
Else, please remove the references.

You can include the cmake files in the -dev package if there are no problems with them.

There are missing copyright notices and BSD licenses in src/util/crc32c.*

Please fix lintian's duplicate-short-description and debian-rules-uses-as-needed-linker-flag.

You should not need to build depend on dh-exec with debhelper 13.

Cheers,
Bastian

Reply to:

Follow-Ups:
- Bug#996592: RFS: workflow/0.9.8-1 [ITP] -- Parallel computing and asynchronous web server engine
  - From: Niels Thykier <niels@thykier.net>

References:
- Bug#996592: RFS: workflow/0.9.8-1 [ITP] -- Parallel computing and asynchronous web server engine
  - From: Lance Lin <LQi254@protonmail.com>

Prev by Date: Processed: RFS: gammu/1.42.0-5~bpo11+1 -- mobile phone management utility
Next by Date: Processed: moreinfo
Previous by thread: Processed: Bug#996592: RFS: workflow/0.9.8-1 [ITP] -- Parallel computing and asynchronous web server engine
Next by thread: Bug#996592: RFS: workflow/0.9.8-1 [ITP] -- Parallel computing and asynchronous web server engine
Index(es):
- Date
- Thread