[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#915524: Acknowledgement (RFS: filemanager-actions/3.4-1 [ITP])



 Hi,

I apologize for the late review. Reviewing your package has been on my
todo list for several weeks. I think it will be appropriate for us to
ask for an exception to ensure it gets into the Buster release even
though it will be a bit late from the freeze deadline.

I imported your git repo to
https://salsa.debian.org/debian/filemanager-actions and gave you
access to it. I also pushed a small update to your debian/gbp.conf
there.

I don't need you to upload changes to mentors, I prefer sponsoring
from the git repo instead of from a .dsc.

1. Could you rename the extension packages to nautilus-extension-fma, etc. ?

2. Why do you have gtk-doc stuff in your -dev package instead of in
your -doc package?

3. Could you just not install the .la files?

4. I think your debian/source/options is unnecessary.

5. I don't think your backup.tar stuff is necessary at all. I
recommend removing all of it.

Other Comments: No Action Needed Before Upload
--------------------------
6. If you don't like autotools clutter, I suggest you work with
upstream to switch the package to meson later.

7. Please ask upstream to provide an app icon that is at least 64px so
we can drop all the svg conversion handling and that autopkgtest.

8. You might want to work with upstream to remove the scrollkeeper/omf
stuff. scrollkeeper was removed from Debian recently and isn't
necessary or used any more. That should allow you to drop nocheck.

Thanks,
Jeremy Bicha


Reply to: