On Mon, May 02, 2016 at 08:31:04PM +0200, Elimar Riesebieter wrote:
> > * what's this (undocumented) change?
> > - dh $@ --with autoreconf
> > + dh $@ --with autoreconf -if
>
> A new package is uploaded where the above is explained in changelog.
+ * Added -if option to autoreconf as advised from upstream.
No.
This doesn't make any sense, you added it to `dh`, no to autoreconf.
Which, to be complete, it's already called with '-f -i' by dh_autoreconf
(and it's even documented in the manpage, if you don't run the build
with debhelper in verbose mode).
What adding '-if' to dh accomplishes is only having it carried through
all dh_* programs, in the form of -O-if (as they are made to accept also
non-recognized options), and for sure it's not passed to the final
autoreconf.
That said, I'd also like to see such changelog lines to explain *why*
something has been done, I surely don't do everything that my upstreams
would like me to do, unless they provide a reason to do so.
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature