Bug#751009: RFS: ppp-gatekeeper/0.1.0-201406111015-1 [ITP]

[Eriberto <eriberto@eriberto.pro.br>]

Hi Nigel,

Your package appears good. We need some last changes to upload it.

2014-09-07 12:36 GMT-03:00 Nigel Kukard <nkukard@lbsd.net>:
> Hi there Eriberto,
>
> No problem at all, I really do appreciate your time :)


Oh, thanks! I saw your work, applying the corrections pointed by all
people. So, I will try to help you to finish this package.

My new observations:

1. d/control: remove the name 'PPP Gatekeeper' from short description
because when anyone execute an 'apt-cache search', the package name
will be showed. Do an '$ apt-cache search a' and you will see that the
packages names aren't showed in short descriptions.

2. d/copyright:
    - About your question, yes, you need split to 'Files: *' and
'Files: debian/*'. The Nigel upstream and Nigel packager can do
different works. Imagine you have your upstream program as 2001-2013
and a package did in 2005. However, you need fix some issues in
packaging. So, you will have an upstream code 2001-2013 and a
packaging 2005-2014 (in other words, your program isn't copyrighted
2014). You can see two examples here[1][2].

[1] http://metadata.ftp-master.debian.org/changelogs/main/v/volatility-profiles/unstable_copyright
[2] http://metadata.ftp-master.debian.org/changelogs/main/p/phpwebcounter-extra/unstable_copyright

    - Other issue is that ppp-gatekeeper file says: "Copyright (C)
2008-2014, Linux Based Systems Design". Your d/copyright say:
"Copyright (C) 2010-2014, Linux Based Systems Design". Note that here
we have another issue: the upstream is Linux Based Systems Design and
the packager is  Nigel Kukard. They aren't the same person. So, we
have:

Files: *
Copyright: 2008-2014 Linux Based Systems Design
License: GPL-3+

Files: debian/*
Copyright: 2014 Nigel Kukard <nkukard@lbsd.net>
License: GPL-3+

I always like to put a contact for upstream. So, I suggest it
(implement if you like this):

Files: *
Copyright: 2008-2014 Linux Based Systems Design,
                                by Nigel Kukard <nkukard@lbsd.net>
License: GPL-3+

You can see an example here[3].

[3] http://metadata.ftp-master.debian.org/changelogs/main/c/core-network/unstable_copyright

3. ppp-gatekeeper.README.Debian: you wrote "Shorewall is a recommended
package". Change from recommended to suggested.

4. As curiosity, why you says 'Source:
https://gitlab.devlabs.linuxassist.net/ppp-gatekeeper/ppp-gatekeeper'
in d/copyright but uses
'http://download.allworldit.org/ppp-gatekeeper' in d/watch?

5. You have a Lintian message to fix: 'P: ppp-gatekeeper:
maintainer-script-without-set-e postrm'.[4]

[4] https://lintian.debian.org/tags/maintainer-script-without-set-e.html

I need your last effort to be all right. :-)

Cheers,

Eriberto