Bug#722710: apt: Incorrect error message for missing data.tar.* segment.

[Len Sorensen <lennartsorensen@ruggedcom.com>]

Package: apt
Version: 0.9.11.3
Severity: normal

I just spent half an hour trying to figure out why I was getting the error:

E: This is not a valid DEB archive, it has no 'data.tar.gz', 'data.tar.bz2' or 'data.tar.lzma' member

Given I knew the package in question was supposed to use .xz, I figured
I must have a problem with dpkg or apt or debootstrap.

When I finally checked the apt source code I found:

   if (!CheckMember("data.tar.gz") &&
       !CheckMember("data.tar.bz2") &&
       !CheckMember("data.tar.lzma") &&
       !CheckMember("data.tar.xz")) {
      // FIXME: add data.tar.xz here - adding it now would require a Translation round for a very small gain
      _error->Error(_("This is not a valid DEB archive, it has no '%s', '%s' or '%s' member"), "data.tar.gz", "data.tar.bz2", "data.tar.lzma");
      return;
   }

So clearly, data.tar.xz would not actually be a problem, but someone
didn't think it was important enough to have a proper error message that
mentioned this leading me and a coworker down the wrong track entirely.

The real problem turns out to be that the package got mangled instead
and didn't have any data.tar.* at all (investigating how that is possible
to do now).

Could this FIXME please get done?  It's not done in squeeze, nor wheezy,
not jessie or even sid.  Has there really not been any reason to update
a translation for anything in apt in this long?

Please get the string updated.  It is very confusing when you encounter
it as it is now.  The gain is not nearly as small as whoever wrote that
comment thought it was.

-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
powerpc

Kernel: Linux 3.10-1-amd64 (SMP w/1 CPU core)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages apt depends on:
ii  debian-archive-keyring  2012.4
ii  gnupg                   1.4.14-1
ii  libapt-pkg4.12          0.9.11.3
ii  libc6                   2.17-92+b1
ii  libgcc1                 1:4.8.1-10
ii  libstdc++6              4.8.1-10

apt recommends no packages.

Versions of packages apt suggests:
pn  apt-doc     <none>
ii  aptitude    0.6.8.2-1.2
ii  dpkg-dev    1.17.1
ii  python-apt  0.8.9.1+b1
ii  synaptic    0.80.3
ii  xz-utils    5.1.1alpha+20120614-2

-- no debconf information