[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#717891: Apt 0.9.9.3 + Acquire::http::Proxy = 400 Bad Request



On Fri, Jul 26, 2013 at 7:51 AM,  <sacrificial-spam-address@horizon.com> wrote:
> The old apt package, which worked, sent the following request
> to the proxy:
>
> GET http://http.us.debian.org/debian/dists/unstable/InRelease HTTP/1.1
> Host: http.us.debian.org
> Cache-Control: max-age=0
> Accept: text/*
> If-Modified-Since: Fri, 26 Jul 2013 02:41:21 GMT
> User-Agent: Debian APT-HTTP/1.3 (0.9.9.2)
>
> The new one sends the following, which omits the protocol and host
> prefix fron the GET line, making it not a proper proxy request:
>
> GET /debian/dists/unstable/InRelease HTTP/1.1
> Host: http.us.debian.org
> Cache-Control: max-age=0
> Accept: text/*
> If-Modified-Since: Fri, 26 Jul 2013 02:41:21 GMT
> User-Agent: Debian APT-HTTP/1.3 (0.9.9.3)

Thanks for the report!

This is a regression from the "Do not send a connection: keep-alive, at all"
commit ( 2b9c9b7f28b18f6ae3e422020e8934872b06c9f3 )
[which wasn't included in the changelog by accident it seems].

The RFC requires absolute URIs in request to proxies:
http://www.w3.org/Protocols/rfc2616/rfc2616-sec5.html

The RFC mentions that all servers must accept an absolute URI in the
request, but attached patch goes back to the old behavior of just sending
absolute URIs if a proxy is used just to be sure.


Best regards

David Kalnischkies

Attachment: 0001-request-absolute-URIs-from-proxies-again-0.9.9.3-reg.patch
Description: Binary data


Reply to: