Bug#1031971: libxfce4panel-2.0-dev fails to build with valac installed
Package: libxfce4panel-2.0-dev
Version: 4.18.1-1
Severity: serious
Tags: ftbfs patch
Justification: fails to build from source (but built successfully in the past)
Dear Maintainer,
To reproduce the problem please follow these steps:
$ sudo apt install valac
$ apt-get source libxfce4panel-2.0-dev
$ cd xfce4-panel-4.18.1
$ sudo apt-get build-dep .
$ dpkg-buildpackage -j`nproc`
Output:
================================================================================
...
dh_compress
dh_fixperms
debian/rules override_dh_missing
make[1]: Entering directory '/home/spinal/tmp/xfce4-panel-4.18.1'
dh_missing --fail-missing -X .la
dh_missing: warning: usr/share/vala/vapi/libxfce4panel-2.0.deps exists in debian/tmp but is not installed to anywhere
dh_missing: warning: usr/share/vala/vapi/libxfce4panel-2.0.vapi exists in debian/tmp but is not installed to anywhere
The following debhelper tools have reported what they installed (with files per package)
* dh_install: gir1.2-libxfce4panel-2.0 (1), libxfce4panel-2.0-4 (3), libxfce4panel-2.0-dev (5), xfce4-panel (18)
* dh_installdocs: gir1.2-libxfce4panel-2.0 (0), libxfce4panel-2.0-4 (0), libxfce4panel-2.0-dev (0), xfce4-panel (1)
* dh_installman: gir1.2-libxfce4panel-2.0 (0), libxfce4panel-2.0-4 (0), libxfce4panel-2.0-dev (0), xfce4-panel (1)
If the missing files are installed by another tool, please file a bug against it.
When filing the report, if the tool is not part of debhelper itself, please reference the
"Logging helpers and dh_missing" section from the "PROGRAMMING" guide for debhelper (10.6.3+).
(in the debhelper package: /usr/share/doc/debhelper/PROGRAMMING.gz)
Be sure to test with dpkg-buildpackage -A/-B as the results may vary when only a subset is built
If the omission is intentional or no other helper can take care of this consider adding the
paths to debian/not-installed.
dh_missing: error: missing files, aborting
make[1]: *** [debian/rules:16: override_dh_missing] Error 255
make[1]: Leaving directory '/home/spinal/tmp/xfce4-panel-4.18.1'
make: *** [debian/rules:7: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
================================================================================
To fix the issue I propose including valac to package build dependencies
and include vala api files to libxfce4panel-2.0-dev.
These vala api files are useful when you wish to build some xfce plugins
from vala sources. One example is xfce4-notes-plugin which I was trying
to build and found that vala api files are missing in Debian distribution.
Please keep in mind that building libxfce4panel-2.0-dev will also fail if
you didn't install libxfce4util-1.0 with vala api files. It means that
Debian bug #1031967 should be resolved first to satisfy vala api deps of
this package.
For possible fix check the following patch.
-- System Information:
Debian Release: bookworm/sid
APT prefers testing
APT policy: (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 6.1.0-3-amd64 (SMP w/8 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=ru_RU.UTF-8, LC_CTYPE=ru_RU.UTF-8 (charmap=UTF-8), LANGUAGE=ru_RU:ru
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages libxfce4panel-2.0-dev depends on:
ii gir1.2-libxfce4panel-2.0 4.18.1-1
ii libglib2.0-dev 2.74.5-1
ii libgtk-3-dev 3.24.36-4
ii libxfce4panel-2.0-4 4.18.1-1
ii libxfce4util-dev 4.18.1-1
libxfce4panel-2.0-dev recommends no packages.
libxfce4panel-2.0-dev suggests no packages.
-- no debconf information
diff -Naur xfce4-panel-4.18.1-orig/debian/control xfce4-panel-4.18.1/debian/control
--- xfce4-panel-4.18.1-orig/debian/control 2023-01-12 10:55:51.000000000 +0300
+++ xfce4-panel-4.18.1/debian/control 2023-02-26 05:33:54.816823882 +0300
@@ -19,6 +19,7 @@
libxfce4ui-2-dev (>= 4.17.1),
libxfce4util-dev (>= 4.17.2),
libxfconf-0-dev,
+ valac,
xfce4-dev-tools
Rules-Requires-Root: no
Standards-Version: 4.6.2
diff -Naur xfce4-panel-4.18.1-orig/debian/libxfce4panel-2.0-dev.install xfce4-panel-4.18.1/debian/libxfce4panel-2.0-dev.install
--- xfce4-panel-4.18.1-orig/debian/libxfce4panel-2.0-dev.install 2022-08-29 02:22:07.000000000 +0300
+++ xfce4-panel-4.18.1/debian/libxfce4panel-2.0-dev.install 2023-02-26 05:34:23.929239264 +0300
@@ -3,3 +3,4 @@
usr/lib/*/pkgconfig/libxfce4panel-2.0.pc
usr/share/gtk-doc/html/libxfce4panel-2.0
usr/share/gir-1.0/*
+usr/share/vala/vapi/*
Reply to: