[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#697745: marked as done (mesa: [PATCH] minor packaging cleanups)

Your message dated Sun, 2 Mar 2014 20:10:15 +0100
with message-id <20140302191015.GD17725@betterave.cristau.org>
and subject line Re: Bug#697745: mesa: [PATCH] minor packaging cleanups
has caused the Debian Bug report #697745,
regarding mesa: [PATCH] minor packaging cleanups
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
697745: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=697745
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: mesa
Version: debian-experimental branch
Severity: wishlist

Dear Maintainers,

here are some cleanup suggestions and patches for debian-experimental:

1) remove explicit forcing of --enable-shared-glapi , it is already
enabled by default where it is useful (i.e. match what debian is using);

2) remove 13-llvm-config-pick-a-version.diff patch and rather just add
--with-llvm-prefix=/usr/lib/llvm-3.2 config flag;

3) add empty LDFLAGS along CFLAGS and CXXFLAGS, useful for building
with -flto (patch attached);

4) recommends-dxtn.patch: Recommends libtxc-dxtn0 (already reported as
bug 668645) (patch attached).

Thanks 

diff --git a/debian/rules b/debian/rules
index 248e7a0..f6e50cc 100755
--- a/debian/rules
+++ b/debian/rules
@@ -7,12 +7,15 @@
 
 CFLAGS = -Wall -g
 CXXFLAGS = -Wall -g
+LDFLAGS =
 ifneq (,$(filter noopt,$(DEB_BUILD_OPTIONS)))
 	CFLAGS += -O0
 	CXXFLAGS += -O0
+	LDFLAGS +=
 else
 	CFLAGS += -O2
 	CXXFLAGS += -O2
+	LDFLAGS +=
 endif
 ifneq (,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))
 	NUMJOBS = $(patsubst parallel=%,%,$(filter parallel=%,$(DEB_BUILD_OPTIONS)))
@@ -54,7 +57,8 @@ include /usr/share/quilt/quilt.make
 
 confflags-common = \
 	CFLAGS="$(CFLAGS)" \
-	CXXFLAGS="$(CXXFLAGS)"
+	CXXFLAGS="$(CXXFLAGS)" \
+	LDFLAGS="$(LDFLAGS)"
 
 DRI_DRIVERS =
 GALLIUM_DRIVERS =
@@ -136,7 +140,8 @@ confflags-swx11 = \
 	--disable-egl \
 	--disable-shared-glapi \
 	CFLAGS="$(CFLAGS)" \
-	CXXFLAGS="$(CXXFLAGS)"
+	CXXFLAGS="$(CXXFLAGS)" \
+	LDFLAGS="$(LDFLAGS)"
 
 confflags-swx11-static = \
 	--disable-dri \
@@ -147,7 +152,8 @@ confflags-swx11-static = \
 	--disable-egl \
 	--disable-shared-glapi \
 	CFLAGS="$(CFLAGS)" \
-	CXXFLAGS="$(CXXFLAGS)"
+	CXXFLAGS="$(CXXFLAGS)" \
+	LDFLAGS="$(LDFLAGS)"
 
 confflags-swx11-i386-i686 = \
 	--disable-dri \
@@ -157,7 +163,8 @@ confflags-swx11-i386-i686 = \
 	--disable-egl \
 	--libdir=/usr/lib/$(DEB_HOST_MULTIARCH)/i686/cmov \
 	CFLAGS="$(CFLAGS) -march=i686" \
-	CXXFLAGS="$(CXXFLAGS) -march=i686"
+	CXXFLAGS="$(CXXFLAGS) -march=i686" \
+	LDFLAGS="$(LDFLAGS)"
 
 configure: $(QUILT_STAMPFN) configure.ac
 	autoreconf -vfi

--- a/debian/control
+++ b/debian/control
@@ -603,6 +603,7 @@ Architecture: any
 Depends:
  ${shlibs:Depends},
  ${misc:Depends}
+Recommends: libtxc-dxtn0
 Suggests: libglide3
 Conflicts: xlibmesa-dri (<< 1:7.0.0)
 Replaces: xlibmesa-dri (<< 1:7.0.0), libgl1-mesa-dri-experimental (<< 7.11.1)

--- End Message ---
--- Begin Message --- 
On Wed, Jan  9, 2013 at 09:59:59 +0100, Fabio Pedretti wrote:

> Package: mesa
> Version: debian-experimental branch
> Severity: wishlist
> 
> Dear Maintainers,
> 
> here are some cleanup suggestions and patches for debian-experimental:
> 
> 1) remove explicit forcing of --enable-shared-glapi , it is already
> enabled by default where it is useful (i.e. match what debian is using);
> 
I prefer the explicit --enable here.

> 2) remove 13-llvm-config-pick-a-version.diff patch and rather just add
> --with-llvm-prefix=/usr/lib/llvm-3.2 config flag;
> 
Done, as mentioned in a followup.

> 3) add empty LDFLAGS along CFLAGS and CXXFLAGS, useful for building
> with -flto (patch attached);
> 
This should no longer be necessary with dpkg-buildflags, I think?

> 4) recommends-dxtn.patch: Recommends libtxc-dxtn0 (already reported as
> bug 668645) (patch attached).
> 
That other bug is closed, so I guess that's taken care of.

Thanks for your report.

Cheers,
Julien

Attachment: signature.asc
Description: Digital signature


--- End Message ---
Reply to: