Hello Dimitry, On 06/09/15 09:05 PM, Dmitry Smirnov wrote: > On Sunday 06 September 2015 20:13:59 Alexandre Viau wrote: >> Those changes make the packaging simpler. > > I've realised we can make it even simpler. :) > > What if we remove > > rm --verbose _build/src/github.com/rainycape/unidecode/table.go > > and replace it with "debian/clean" files with "table.go" (without quotes) in > it? It is simpler because "table.go" will be removed by `dh_clean` hence it > won't be copied to build directory therefore we will not need to remove it > from there. I like it more because it is better to drop pre-generated files > from source tree (`make clean` style) before build to make sure they are not > used at all. > > This is my last packaging concern and I'm ready to upload. Please let me know > what do you think about this last minute improvement idea. I think this is equivalent. However, I think that removing table.go and adding table.txt is linked and I would prefer if both operations stayed at the same place. I think it is simpler for people that read the packaging. -- Alexandre Viau alexandre@alexandreviau.net
Attachment:
signature.asc
Description: OpenPGP digital signature