Re: Removal requests submitted for CERNLIB packages
Hi Bastian,
at first thanks to your work on this!
On Mon, Mar 14, 2011 at 10:48:56AM +0100, roucaries bastien wrote:
> I have just uploaded the fist part under mentors for comments
I have downloaded these files. Here are my remarks:
Please provide a get-orig-source target in debian/rules which enables
others to recreate the tarball. I usually provide a script
debian/get-orig-source
and make the target
get-orig-source:
. debian/get-orig-source
because it is sometimes more easy to have shell code in a shell script.
This would make some text in your debian/copyright superfluous and a
file debian/README.source would be more apropriate to document the
reasons why some files are missing from the downloadable tarball. This
has the following advantages:
1. It is easily to reproduce what you have done to create the tarball.
2. It makes no sense to blur the debian/copyright file with mentioning
things your are *not* providing.
When trying to build I get a warning:
/usr/share/cdbs/1/rules/buildcore.mk:109: WARNING: DEB_DH_STRIP_ARGS is a deprecated variable
Recently I observed that several packages in Debian Med FTBFS because
cdbs changed its API. I decided to fix this by completely droping cdbs
in favour of dh which is in my eyes way more logical then seeking
incomplete docs for the magic variable I need to set (while these
variables are obviosely not stable). I will not put my personal
preference on you - but I wanted to let you know this.
If you build the package using pbuilder you are running into two errors
cd . && libtoolize -c -f
/bin/sh: libtoolize: not found
make: *** [debian/stamp-autotools-files] Error 127
and the other is a missing unifdef command. These can be fixed with the
following patch:
--- cernlib-2006-dfsg.3.orig/debian/control 2011-03-12 23:17:12.000000000 +0100
+++ cernlib-2006-dfsg.3/debian/control 2011-03-14 15:03:03.000000000 +0100
@@ -8,7 +8,8 @@
Homepage: http://cernlib.web.cern.ch/cernlib/
Vcs-Git: git://git.debian.org/git/debian-science/packages/cernlib.git
Vcs-Browser: http://git.debian.org/?p=debian-science/packages/cernlib.git
-Build-Depends: debhelper (>= 8.0), autotools-dev, autoconf, automake, cdbs, autoconf-archive, quilt, gfortran (>= 4:4.3), cfortran (>= 4.4-10)
+Build-Depends: debhelper (>= 8.0), autotools-dev, autoconf, automake, cdbs, autoconf-archive,
+ libtool, quilt, gfortran (>= 4:4.3), cfortran (>= 4.4-10), unifdef
Build-Conflicts: autoconf2.13, automake1.4
Package: libcernpackminuit3
It would probably a good idea if you would commit the Debian packaging
directory into
git://git.debian.org/git/debian-science/packages/cernlib.git
I would have commited straigt into Vcs if this would be the case.
(Please reread Debian Science policy how to work with Git.)
Finally there are some lintian problems:
E: cernlib source: unknown-file-in-debian-source git-patches
E: libcernpackminuit3-dbg: copyright-should-refer-to-common-license-file-for-gpl
W: libcernpackminuit3-dev: extended-description-line-too-long
W: libcernpackminuit3: binary-without-manpage usr/bin/cernminuit
I: libcernpackminuit3: spelling-error-in-binary ./usr/lib/libcernpackminuit.so.3.0.0 preceeded preceded
Some of them need fixing some could be fixed.
Kind regards
Andreas.
--
http://fam-tille.de
Reply to: