Re: ruby-gemojione and gem-install
On 2016, ആഗസ്റ്റ് 26 6:06:36 PM IST, Antonio Terceiro <terceiro@debian.org> wrote:
>On Fri, Aug 26, 2016 at 07:45:29AM +0530, Pirate Praveen wrote:
>>
>>
>> On 2016, ആഗസ്റ്റ് 26 12:35:33 AM IST, Antonio Terceiro
><terceiro@debian.org> wrote:
>> >On Thu, Aug 25, 2016 at 04:01:11PM -0300, Antonio Terceiro wrote:
>> >> On Thu, Aug 25, 2016 at 01:31:48PM +0530, Pirate Praveen wrote:
>> >> > On Tuesday 23 August 2016 07:58 PM, Antonio Terceiro wrote:
>> >> > > On Tue, Aug 23, 2016 at 06:48:01PM +0530, Pirate Praveen
>wrote:
>> >> > >> Thanks, this is working. I can fix ruby-fog-openstack
>> >autopkgtest
>> >> > >> failures easily once this is uploaded (it would be helpful to
>> >remove
>> >> > >> patches from many packages/fix autopkgtests etc as well), see
>> >> > >> gem-install branch.
>> >> > >
>> >> > > OK, I'm building gem2deb for making an upload right now.
>> >> > >
>> >> >
>> >> > I can only add top level directories it seems. I tried adding
>> >> > tests/fixtures to whitelist but it did not work, it worked when
>I
>> >added
>> >> > just tests.
>> >>
>> >> OK. But why on earth would you want to install test fixtures?
>> >
>> >or tests, even
>>
>> For autopkgtest. I could probably patch the tests but less work is
>installing tests/fixtures.
>
>nooooo ... :-o
>
>autopkgtest already runs the tests from the source tree, there is no
>point in installing the tests in the binary. what you need to make sure
>is that _code_ being tested is the one installed and not the one in the
>source tree (gem2deb-test-runner does that for you transparently by
>moving lib/ and ext/ away); the tests themselves can be the ones in the
>source tree.
For ruby-fog-openstack, tests try to look for fixtures relative to the loaded library path. This was a quick and dirty fix. autopkgtest was failing without installing tests.
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
Reply to: