Hi Sam,
On Wed, Jul 31, 2013 at 02:06:04PM -0400, Sam Kottler wrote:
> Hi!
> The following packages are ready to be uploaded (I also verified the points
> listed on http://wiki.debian.org/Teams/Ruby/Packaging#Requesting_Sponsorship
> ).
> Is someone willing to sponsor them?
> ruby-rkerberos 0.1.2
> Here is the page on mentors.debian.net -
> https://mentors.debian.net/package/ruby-rkerberos.
I had a quick look at your package. Here are a few comments that could
allow you to improve your package:
naive question from someone with little knowledge about Kerberos: how
does it compare to ruby-krb5-auth?
debian/copyright:
- you indicate Artistic 2.0 for the license, but the text in this
paragraph refers to GPL-2+.
- unless you have a strong opinion about the license you use,
use the same license as upstream as it makes easier distribution of
your work.
- the only place where the license is indicated is the gemspec
metadata. Maybe ask upstream to include the text of the license in
the source
debian/control:
- there is a commented line below Depends: field which can be removed.
- there is no mention of Ruby in the long description.
- Vcs-* fields are commented. If you consider maintaining this package
under Ruby team's umbrella, uncomment those fields, and ask to join
the team on Alioth and import the package to the team repository
debian/ruby-rkerberos.docs
- remove the first line and uncomment the second to include the README
in usr/share/doc/ruby-rkerkeros
tests:
- tests are run but fail:
/usr/lib/ruby/vendor_ruby/1.8/rubygems/dependency.rb:247:in `to_specs': Could not find test-unit (>= 0) amongst [] (Gem::LoadError)
A build-dependency on ruby-test-unit is missing. You'll need to
package ruby-dbi-dbrc (http://rubygems.org/gems/dbi-dbrc) if you want
to run all the tests (test_kadm5.rb needs it).
- all tests have a "require 'rubygems'" and "gem 'test-unit'" . You
should patch them out
with quilt (and add a DEP-3 header to the patch
http://dep.debian.net/deps/dep3/)
- do not ignore test failures in debian/rules
lintian gives some messages:
P: ruby-rkerberos source: debian-control-has-unusual-field-spacing line 5
I: ruby-rkerberos: hardening-no-fortify-functions usr/lib/ruby/vendor_ruby/1.8/x86_64-linux/rkerberos.so
I: ruby-rkerberos: hardening-no-fortify-functions usr/lib/ruby/vendor_ruby/1.9.1/x86_64-linux/rkerberos.so
I: ruby-rkerberos: extended-description-is-probably-too-short
Cheers,
Cédric
Attachment:
signature.asc
Description: Digital signature