Hi Praveen, On Thu, Jun 06, 2013 at 09:13:58PM +0530, Praveen A wrote: > 2013/6/4 Praveen A <praveen@debian.org>: > > uploaded ruby-em-socksify and ruby-http-parser (also needed as build > > dep). It still needs cookiejar (it doesn't have a test helper and I > > have to try adding correct requires to make tests run, not sure if it > I prepared cookiejar package (its in the repo). It had two test > failures. I patched the tests to make it pass. But I'm not sure if it > is the right way. > Can someone review it? > http://anonscm.debian.org/gitweb/?p=pkg-ruby-extras/ruby-cookiejar.git;a=blob;f=debian/patches/fix-test-failures-remove-rubygems.patch;h=b3cf4bdd577ac03d3843f2ff2b26f464c936caa1;hb=HEAD I had a look at the tests and it seems the author wanted to test creation of objects directly from JSON. (Un)fortunately, after CVE-2013-026 has been fixed, creation of objects from JSON parsing needs an additional option ::create_additions to be set to true. I did that instead, and split the patch in two parts,separating rubygems stuff. I've just forwarded upstream the part about JSON. I've also removed the first line of the long description in debian/control, which seems to be a repetition of the better text below it. Please check the two last commits in the team repo. Cheers, Cédric
Attachment:
signature.asc
Description: Digital signature