Bug#1034755: x2gothinclient-common: about .postinst and .postrm scripts
Package: x2gothinclient-common
Version: 1.5.0.1-8.1
Severity: wishlist
Dear Maintainer,
To be consistent, regarding the entire content of the .postinst script,
I think it should use addgroup in line 49 (compared to line 30 and the
use of adduser and not useradd everywhere else).
Also during a test with piuparts I noticed your package failed to purge due
to a command not found. According to policy 7.2 you cannot rely on the
depends being available during purge, only the essential packages are
available for sure.
The fix should be easy: your package is using adduser/addgroup or
deluser/delgroup
from the adduser package, which is only priority important. Using
useradd/groupadd
or userdel/groupdel from the passwd package (priority required) should fix this
problem.
There is ongoing discussion how to handle system users/groups on package
removal, see https://bugs.debian.org/621833
Consensus seems to be not to remove system users/groups (to avoid reusing
UIDs/GIDs
which could grant access to the wrong files) but to "lock" them (where
"locking"/"unlocking" is not yet precisely defined). Until that has
been decided it should be sufficient to have the postrm script ignore
any errors from deluser/delgroup:
deluser/delgroup ... || true
The piupart log is here:
https://piuparts.debian.org/sid/fail/x2gothinclient-common_1.5.0.1-8.1.log
Thanks,
Patrice
-- System Information:
Debian Release: 12.0
APT prefers unstable-debug
APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 6.1.0-7-amd64 (SMP w/12 CPU threads; PREEMPT)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages x2gothinclient-common depends on:
ii adduser 3.132
ii x2goclient 4.1.2.2-2+b1
x2gothinclient-common recommends no packages.
x2gothinclient-common suggests no packages.
Reply to: