[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1059898: unblock: steam-installer/1:1.0.0.78~ds-4



Hi Simon,

On 03-01-2024 10:34, Simon McVittie wrote:
In the HTML output, under "Additional info" (which if I understand
correctly is meant to be for notes that do not affect migration),

That's the idea, yes.

it
says:

- Additional info:
     - uninstallable on arch amd64, not running autopkgtest there
     - uninstallable on arch i386, not running autopkgtest there

I recently (some weeks/months ago) enhanced britney2 to take the results of the InstallabilityPolicy into account before scheduling autopkgtests, to prevent failures due to "can't install". By the looks of it, the passing of data goes wrong, because I wouldn't expect this autopkgtest info *without* a negative verdict from the InstallabilityPolicy. Obviously it's not the task of the AutopkgtestPolicy to prevent migration due to non-installability.

but in the YAML output, I see that actually this might be the reason why
it isn't migrating:

     autopkgtest:
       verdict: REJECTED_TEMPORARILY
   ...
   reason:
   - autopkgtest

I find this confusing, because steam-installer doesn't have any autopkgtest
coverage at all.

Well, the AutopkgtestPolicy also schedules tests for reverse dependencies and this check happens *before* britney even calculated those.

The steam-installer:amd64 contrib binary package is uninstallable if you
don't have an i386 foreign architecture added, because Valve's proprietary
code has hard dependencies on both amd64 and i386 libraries.

Hmm, interesting. Probably my new code doesn't deal with this possibility at all, while apparently the InstallabilityPolicy is smarter.

Is this
perhaps what the migration software is unhappy about? But I thought we
could have uninstallable packages as long as they are not a regression?

Well, I suspect this is in new code. It probably just doesn't support this corner case (because I wasn't aware of it and I might have made wrong assumptions).

Similarly, the steam:i386 contrib binary package is uninstallable unless
you are actually on an amd64 system.

Ack.

The other binary packages (in main) should be installable on their
appropriate architectures with no special measures.

The AutopkgtestPolicy looks at the joined installability of all binaries on an arch.

Thanks for letting us know. I prefer to keep the status quo for a day such that I can debug this tomorrow. I hope to add a hint at the end of the day (if I don't forget, feel free to ping me if I do).

Paul

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature


Reply to: