[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1032939: unblock: network-manager/1.42.4-1



Hi Paul,

sorry for the late reply.
Fortunately, the additional delay has given the changes in unstable further testing and no new bug reports have been filed since then.

Am 18.03.23 um 22:17 schrieb Paul Gevers:
Control: tags -1 moreinfo

Hi Michael,

On 14-03-2023 13:47, Michael Biebl wrote:
please unblock package network-manager.

The current version in testing is 1.42.0-1 and upstream has created two
stable point releases 1.42.2 and 1.42.4, cherry-picking various fixes
into the nm-1.42 stable branch, most notably a fix for #1031891,
a regression in the dnsmasq DNS backend when using a global DNS
configuration.

Upstream is rather conservative in cherry-picking fixes into their
stable branches and the package ships an extensive test-suite, which is
run during build.

What does "rather conservative" mean? Do you have a link to their policy?

I don't think upstream has an explicit document here which I could link to, at least not one that I'm aware of. So the statement above is mostly from (my) past experience dealing with upstream.


Normally we'd like to have a more verbose description of the changes. The diff is uncomfortably big. Please try to avoid white space changes next time too (debian/org.freedesktop.NetworkManager.rules), those are horrible to review.

Noted. The man pages are generated from .xml files, so could be excluded as well.
Do you want me to send an update with a more trimmed down debdiff?

Is there a reason why you "Use execute_before
instead of override for dh_install" now?

This is a cosmetic change, mostly and something I've done in other packages as well, whenever I touched them. It doesn't change anything functionality wise but avoids having to specify a separate "dh_install" line.

 > I've filtered out generated files (like Makfile.in) and po/*

Next time, please provide the full filter that you used. I would not have guessed from that line that you stripped a lot of docs/ too.

Indeed, that's a good point.

No new regressions were reported for 1.42.4-1.

I would thus like to see 1.42.4-1 unblocked for bookworm.

Ack. I'm leaning to let it in now, but later in the freeze, please cherry-pick or defer.

Noted. No further update is planned at this point, but I'll definitely keep that in mind.

Thanks,
Michael

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


Reply to: