Bug#1033025: unblock: socklog/2.1.0+repack-5

[Sebastian Ramacher <sramacher@debian.org>]

On 2023-03-16 17:32:25 +0100, Mathieu Mirmont wrote:
> On Thu, Mar 16, 2023 at 02:57:52PM +0100, Sebastian Ramacher wrote:
> > Control: tags -1 moreinfo
> > 
> > Hi Mathieu
> > 
> > On 2023-03-15 23:05:39 +0100, Mathieu Mirmont wrote:
> > > diff -Nru socklog-2.1.0+repack/debian/changelog socklog-2.1.0+repack/debian/changelog
> > > --- socklog-2.1.0+repack/debian/changelog	2020-12-22 22:40:42.000000000 +0100
> > > +++ socklog-2.1.0+repack/debian/changelog	2023-03-06 22:01:18.000000000 +0100
> > > @@ -1,3 +1,15 @@
> > > +socklog (2.1.0+repack-5) unstable; urgency=medium
> > > +
> > > +  * Various uninteresting changes
> > 
> > What are these uninteresting changes?
> 
> Sorry that's not the greatest description indeed. Looking at the git
> commit this is:
> 
> - Use spaces instead of tabs to align columns in d/socklog.install and
>   d/socklog-run.runit.

This is unnecessary noise at this stage of the freeze. For the next
time, please defer such changes. Anyway, unblocked.

Cheers

> - Add set -eu at the top of the d/repack.sh script.
> - Update the copyright date in d/copyright.
> - Include /usr/share/dpkg/buildflags.mk in d/rules.
> - Remove Breaks/Replaces: socklog (<= 2.1.0+repack-3) in d/control
>   (see below for the rationale).
> 
> > > diff -Nru socklog-2.1.0+repack/debian/control socklog-2.1.0+repack/debian/control
> > > --- socklog-2.1.0+repack/debian/control	2020-12-22 22:40:42.000000000 +0100
> > > +++ socklog-2.1.0+repack/debian/control	2023-03-06 21:52:36.000000000 +0100
> > > @@ -37,9 +37,8 @@
> > >           ${misc:Depends}, ${shlibs:Depends}
> > >  Recommends: ipsvd, mailx
> > >  Provides: system-log-daemon, linux-kernel-log-daemon
> > > -Conflicts: system-log-daemon, linux-kernel-log-daemon, ${runit:Conflicts}
> > > -Breaks: socklog (<= 2.1.0+repack-3), ${runit:Breaks}
> > > -Replaces: socklog (<= 2.1.0+repack-3)
> > > +Conflicts: system-log-daemon, linux-kernel-log-daemon
> > > +Breaks: ${runit:Breaks}
> > 
> > What's the rationale behind those changes?
> 
> Until socklog 2.1.0+repack-3 the two binary packages were merged into
> one. That version was never released and bullseye shipped with
> 2.1.0+repack-4 so this Breaks/Replaces is now obsolete.
> 
> Then there's ${runit:Conflicts} and ${runit:Breaks} that expand to the
> same value. Using both seems redundant and Breaks is sufficient since
> the packages can be unpacked at the same time.
> 
> Cheers,
> 
> -- 
> Mathieu Mirmont <mat@parad0x.org>
> 

-- 
Sebastian Ramacher