Re: Bug#1031238: debci: fails for source packages in non-free-firmware

[Paul Gevers <elbrus@debian.org>]

Control: tags -1 confirmed

On 13-02-2023 20:45, Andreas Beckmann wrote:
> src:nvidia-graphics-drivers recently moved from non-free to
> non-free-firmware since the firmware-nvidia-gsp binary package was moved
> to that section, too.

Ack.

> Tracker reports
>   autopkgtest for nvidia-graphics-drivers/n/a: amd64: Regression ♻ (reference ♻), ...
> not sure whether the version "n/a" comes from tracker or debci.

n/a probably comes from autopkgtest (or indeed debci that interprets a 
missing version that way)

> Autopkgtest regresses with
> https://ci.debian.net/data/autopkgtest/testing/amd64/n/nvidia-graphics-drivers/31312665/log.gz
> ...
> autopkgtest [14:12:05]: testbed dpkg architecture: amd64
> autopkgtest [14:12:05]: testbed running kernel: Linux 5.10.0-21-cloud-amd64 #1 SMP Debian 5.10.162-1 (2023-01-21)
> autopkgtest [14:12:06]: @@@@@@@@@@@@@@@@@@@@ apt-source nvidia-graphics-drivers
> blame: nvidia-graphics-drivers
> badpkg: rules extract failed with exit code 1
> autopkgtest [14:12:06]: ERROR: erroneous package: rules extract failed with exit code 1
>
> My guess is that it fails since it cannot find the source package
> anywhere.

Indeed

autopkgtest [09:56:46]: @@@@@@@@@@@@@@@@@@@@ apt-source 
nvidia-graphics-drivers
autopkgtest: DBG: blame += nvidia-graphics-drivers
autopkgtest: DBG: testbed reset: modified=False, deps_installed=[], 
deps_new=[]
autopkgtest: DBG: install_deps: deps_new=[]
autopkgtest: DBG: testbed command ['sh', '-ec', 'command -v 
dpkg-source'], kind short, sout pipe, serr pipe, env []
autopkgtest: DBG: testbed command exited with code 0
autopkgtest: DBG: testbed command ['sh', '-ec', 'su --shell=/bin/sh 
debci -c \'set -e; exec 3>&1 >&2; set -x; cd /; builddir=$(mktemp -d 
/tmp/autopkgtest-lxc.julgi3d7/downtmp/build.XXX); cd $builddir; 
OUT=$(apt-get source -d -q --only-source 
nvidia-graphics-drivers/unstable 2>&1) || RC=$?;\nif [ -n "$RC" ]; 
then\n  if echo "$OUT" | grep -q "Unable to find a source package"; 
then\n    exit 1;\n  else\n    exit $RC;\n  fi;\nfi;\necho "$OUT" | grep 
^Get: || true;\ndpkg-source -x nvidia-graphics-drivers_*.dsc src 
>/dev/null; chmod -R a+rX .; cd [a-z0-9]*/.; pwd >&3; sed -n "1 
{s/).*//; s/ (/\\n/; p}" debian/changelog >&3\''], kind build, sout 
pipe, serr raw, env []
+ cd /
+ mktemp -d /tmp/autopkgtest-lxc.julgi3d7/downtmp/build.XXX
+ builddir=/tmp/autopkgtest-lxc.julgi3d7/downtmp/build.3aA
+ cd /tmp/autopkgtest-lxc.julgi3d7/downtmp/build.3aA
+ apt-get source -d -q --only-source nvidia-graphics-drivers/unstable
+ OUT=Reading package lists...
E: Unable to find a source package for nvidia-graphics-drivers
+ RC=100
+ [ -n 100 ]
+ echo Reading package lists...
E: Unable to find a source package for nvidia-graphics-drivers
+ grep -q Unable to find a source package
+ exit 1
autopkgtest: DBG: testbed command exited with code 1

Adding non-free-firmware to /etc/apt/sources.list fixes that problem. In 
debci, it's bin/debci-generate-apt-sources that on line 133 sets the 
components, but it does so for all suites. This means we'll get

W: Skipping acquire of configured file 
'non-free-firmware/source/Sources' as repository 
'http://deb.debian.org/debian stable InRelease' doesn't have the 
component 'non-free-firmware' (component misspelt in sources.list?)
W: Skipping acquire of configured file 
'non-free-firmware/binary-amd64/Packages' as repository 
'http://deb.debian.org/debian stable InRelease' doesn't have the 
component 'non-free-firmware' (component misspelt in sources.list?)

in our logs on stable (bullseye) if we add it without further logic. 
Just above there's already code that uses the suite, so probably we can 
borrow a bit of that.

Paul

Attachment: OpenPGP_signature
Description: OpenPGP digital signature