Bug#1023550: transition: qcustomplot
Hi Filippo,
On Thu, Nov 24, 2022 at 09:59:49PM +0100, Filippo Rusconi wrote:
> Greetings Sebastian,
>
> On Thu, Nov 24, 2022 at 09:05:07PM +0100, Sebastian Ramacher wrote:
> > Hi Filippo
>
> [...]
>
> > > > Thanks! Please go ahead with the transition.
> > >
> > > I just uploaded the package to unstable. I have not closed the bug yet, waiting
> > > to check that everything goes fine.
> >
> > qcustomplot's autopkgtests are failing. Could you please take a look at
> > them? Thanks
>
> It is weeks that I monitor the salsa stuff, but I do not understand what these
> tests mean. One example (bear with me):
The failures are because cmake could not find the library and so the
variable 'QCustomPlot_LIBRARIES' was empty and so while linking it did not
ask 'ld' to link with libqcustomplot. Please dont ask why.
Try the attached patch which will explicitely ask cmake to find the library
and save it to the variable. It worked in my schroot.
--
Regards
Sudip
diff -Nru qcustomplot-2.1.0+dfsg1/debian/changelog qcustomplot-2.1.0+dfsg1/debian/changelog
--- qcustomplot-2.1.0+dfsg1/debian/changelog 2022-11-25 10:01:09.000000000 +0000
+++ qcustomplot-2.1.0+dfsg1/debian/changelog 2022-12-01 17:36:10.000000000 +0000
@@ -1,3 +1,10 @@
+qcustomplot (2.1.0+dfsg1-3.1) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * Fix autopkgtest.
+
+ -- Sudip Mukherjee <sudipm.mukherjee@gmail.com> Thu, 01 Dec 2022 17:36:10 +0000
+
qcustomplot (2.1.0+dfsg1-3) unstable; urgency=low
* Fix the autopkgtest by fixing the dependencies of libqcustomplot-dev: when
diff -Nru qcustomplot-2.1.0+dfsg1/debian/tests/buildtest-axis qcustomplot-2.1.0+dfsg1/debian/tests/buildtest-axis
--- qcustomplot-2.1.0+dfsg1/debian/tests/buildtest-axis 2022-11-25 10:01:09.000000000 +0000
+++ qcustomplot-2.1.0+dfsg1/debian/tests/buildtest-axis 2022-12-01 16:27:01.000000000 +0000
@@ -19,6 +19,7 @@
FIND_PACKAGE(QCustomPlot REQUIRED)
FIND_PACKAGE(Qt5PrintSupport REQUIRED)
+find_library(QCustomPlot_LIBRARIES QCustomPlot REQUIRED)
set(CMAKE_MODULE_PATH "\${CMAKE_CURRENT_SOURCE_DIR}/cMake")
set(CMAKE_AUTOMOC ON)
diff -Nru qcustomplot-2.1.0+dfsg1/debian/tests/buildtest-inter qcustomplot-2.1.0+dfsg1/debian/tests/buildtest-inter
--- qcustomplot-2.1.0+dfsg1/debian/tests/buildtest-inter 2022-11-25 10:01:09.000000000 +0000
+++ qcustomplot-2.1.0+dfsg1/debian/tests/buildtest-inter 2022-12-01 17:26:26.000000000 +0000
@@ -19,6 +19,7 @@
FIND_PACKAGE(QCustomPlot REQUIRED)
FIND_PACKAGE(Qt5PrintSupport REQUIRED)
+find_library(QCustomPlot_LIBRARIES QCustomPlot REQUIRED)
set(CMAKE_MODULE_PATH "\${CMAKE_CURRENT_SOURCE_DIR}/cMake")
set(CMAKE_AUTOMOC ON)
diff -Nru qcustomplot-2.1.0+dfsg1/debian/tests/buildtest-plot qcustomplot-2.1.0+dfsg1/debian/tests/buildtest-plot
--- qcustomplot-2.1.0+dfsg1/debian/tests/buildtest-plot 2022-11-25 10:01:09.000000000 +0000
+++ qcustomplot-2.1.0+dfsg1/debian/tests/buildtest-plot 2022-12-01 17:26:40.000000000 +0000
@@ -19,6 +19,7 @@
FIND_PACKAGE(QCustomPlot REQUIRED)
FIND_PACKAGE(Qt5PrintSupport REQUIRED)
+find_library(QCustomPlot_LIBRARIES QCustomPlot REQUIRED)
set(CMAKE_MODULE_PATH "\${CMAKE_CURRENT_SOURCE_DIR}/cMake")
set(CMAKE_AUTOMOC ON)
diff -Nru qcustomplot-2.1.0+dfsg1/debian/tests/buildtest-scroll qcustomplot-2.1.0+dfsg1/debian/tests/buildtest-scroll
--- qcustomplot-2.1.0+dfsg1/debian/tests/buildtest-scroll 2022-11-25 10:01:09.000000000 +0000
+++ qcustomplot-2.1.0+dfsg1/debian/tests/buildtest-scroll 2022-12-01 17:26:50.000000000 +0000
@@ -19,6 +19,7 @@
FIND_PACKAGE(QCustomPlot REQUIRED)
FIND_PACKAGE(Qt5PrintSupport REQUIRED)
+find_library(QCustomPlot_LIBRARIES QCustomPlot REQUIRED)
set(CMAKE_MODULE_PATH "\${CMAKE_CURRENT_SOURCE_DIR}/cMake")
set(CMAKE_AUTOMOC ON)
diff -Nru qcustomplot-2.1.0+dfsg1/debian/tests/buildtest-text qcustomplot-2.1.0+dfsg1/debian/tests/buildtest-text
--- qcustomplot-2.1.0+dfsg1/debian/tests/buildtest-text 2022-11-25 10:01:09.000000000 +0000
+++ qcustomplot-2.1.0+dfsg1/debian/tests/buildtest-text 2022-12-01 17:27:05.000000000 +0000
@@ -19,6 +19,7 @@
FIND_PACKAGE(QCustomPlot REQUIRED)
FIND_PACKAGE(Qt5PrintSupport REQUIRED)
+find_library(QCustomPlot_LIBRARIES QCustomPlot REQUIRED)
set(CMAKE_MODULE_PATH "\${CMAKE_CURRENT_SOURCE_DIR}/cMake")
set(CMAKE_AUTOMOC ON)
diff -Nru qcustomplot-2.1.0+dfsg1/debian/tests/control qcustomplot-2.1.0+dfsg1/debian/tests/control
--- qcustomplot-2.1.0+dfsg1/debian/tests/control 2022-11-25 10:01:09.000000000 +0000
+++ qcustomplot-2.1.0+dfsg1/debian/tests/control 2022-12-01 17:35:46.000000000 +0000
@@ -1,2 +1,3 @@
Tests: buildtest-axis buildtest-inter buildtest-plot buildtest-scroll buildtest-text
Depends: libqcustomplot-dev, build-essential, cmake
+Restrictions: allow-stderr
Reply to: