[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#857258: unblock: ifupdown2/1.0~git20170308-1



Hi Niels,

No worries, I understand the new issues raised by my last changes.
I will make the appropriate fixes and submit again.

Thanks for your help.
Julien.

On Fri, Mar 10, 2017 at 12:44 AM, Niels Thykier <niels@thykier.net> wrote:
Control: tags -1 moreinfo

Julien Fortin:
> Package: release.debian.org
> Severity: normal
> User: release.debian.org@packages.debian.org
> Usertags: unblock
>
> Please unblock package ifupdown2
>
> Hi,
>
> This release fixes a bug due to a localized string in a grep filter.
>
> Following up on the comments received during last unblock request. I've added
> the LC_ALL directive to the pre,post inst and postrm files.
>

Hi,

Sorry, this is unfortunately not what I expected and I suspect you
misunderstood my intention/request.


  * I had envisioned $(LC_ALL=C.UTF-8 dpkg-divert ...), which would
    only overwrite the language exactly for the dpkg-divert
    command/pipeline.
  * The proposed change fails to export the variable, so it is not going
    to work except when LC_ALL is already exported (which is not the
    case on all systems)
  * Also, overriding LC_ALL in the entire script completely overrules
    the users locale preventing other messages in the users native
    language.

Apologies for the misunderstanding and having to ask you for a third
attempt.

Thanks,
~Niels



Reply to: