[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#854811: jessie-pu: package gnome-screenshot/3.14.0-1



Package: release.debian.org
Severity: normal
Tags: jessie
User: release.debian.org@packages.debian.org
Usertags: pu

If used without GUI (e.g. by pressing the PrintScr key or from a shell with no
arguments), gnome-screenshot will simply take a screenshot of the whole screen
and store it in the pictures directory with a filename containing the current
timestamp with colons (i.e. "Screenshot from 2017-01-10 16:46:39.png").
This leads to problems with some filesystems (e.g. vfat, ntfs).

See package bug #850836 (https://bugs.debian.org/cgi-
bin/bugreport.cgi?bug=850836)

I have created a patch from a combination of the patch from upstream bug
#698740 and upstream commit aa23783 to achieve the behaviour intended by
successive upstream releases.
The rationale behind this to not just import the bug from the upstream
bug report is to not disrupt user experience once now in Jessie and then
another time when Stretch is released but just once now.

I added the patch to debian/patches, updated the changelog, built the
package, tested it and attached the debdiff here (and FWIW uploaded it
to https://mentors.debian.net/package/gnome-screenshot)

-- System Information:
Debian Release: 8.7
  APT prefers stable-updates
  APT policy: (700, 'stable-updates'), (700, 'stable'), (60, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
diff -Nru gnome-screenshot-3.14.0/debian/changelog gnome-screenshot-3.14.0/debian/changelog
--- gnome-screenshot-3.14.0/debian/changelog	2014-09-23 15:43:32.000000000 +0200
+++ gnome-screenshot-3.14.0/debian/changelog	2017-02-08 11:00:32.000000000 +0100
@@ -1,3 +1,14 @@
+gnome-screenshot (3.14.0-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * filename-builder-use-dash-for-time-format-separator.patch:
+    Combination of the patch from upstream bug #698740 and upstream
+    commit aa23783 to achieve the behaviour intended by successive
+    upstream releases.
+    (Closes: #850836)
+
+ -- Moritz Schlarb <schlarbm@uni-mainz.de>  Wed, 08 Feb 2017 10:28:37 +0100
+
 gnome-screenshot (3.14.0-1) unstable; urgency=medium
 
   * New upstream release.
diff -Nru gnome-screenshot-3.14.0/debian/patches/filename-builder-use-dash-for-time-format-separator.patch gnome-screenshot-3.14.0/debian/patches/filename-builder-use-dash-for-time-format-separator.patch
--- gnome-screenshot-3.14.0/debian/patches/filename-builder-use-dash-for-time-format-separator.patch	1970-01-01 01:00:00.000000000 +0100
+++ gnome-screenshot-3.14.0/debian/patches/filename-builder-use-dash-for-time-format-separator.patch	2017-02-08 10:53:06.000000000 +0100
@@ -0,0 +1,20 @@
+Subject: filename-builder: use dash for time format separator
+
+This patch is a combination of the patch from upstream bug #698740
+and upstream commit aa23783 to achieve the behaviour intended by
+successive upstream releases.
+
+Bug: https://bugzilla.gnome.org/show_bug.cgi?id=698740
+Origin: https://github.com/GNOME/gnome-screenshot/commit/aa23783c39f96dd0b45f70d82557736a5b884c55
+
+--- a/src/screenshot-filename-builder.c
++++ b/src/screenshot-filename-builder.c
+@@ -131,7 +131,7 @@ build_path (AsyncExistenceJob *job)
+       GDateTime *d;
+ 
+       d = g_date_time_new_now_local ();
+-      origin = g_date_time_format (d, "%Y-%m-%d %H:%M:%S");
++      origin = g_date_time_format (d, "%Y-%m-%d %H-%M-%S");
+       g_date_time_unref (d);
+     }
+   else
diff -Nru gnome-screenshot-3.14.0/debian/patches/series gnome-screenshot-3.14.0/debian/patches/series
--- gnome-screenshot-3.14.0/debian/patches/series	1970-01-01 01:00:00.000000000 +0100
+++ gnome-screenshot-3.14.0/debian/patches/series	2017-02-08 10:40:56.000000000 +0100
@@ -0,0 +1 @@
+filename-builder-use-dash-for-time-format-separator.patch

Reply to: