[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#771801: unblock: hobbit-plugins/20141201



Package: release.debian.org
Severity: normal
User: release.debian.org@packages.debian.org
Usertags: unblock

Please unblock hobbit-plugins/20141201

It fixes the following bug with severity "important":

#770467 [i|+| ] [hobbit-plugins] hobbit-plugins: client-ext/apt: Warning: Use of uninitialized value $cand in string eq at /usr/lib/hobbit/client/ext/apt line 206, …

See https://bugs.debian.org/770467 for details.

Full source debdiff:

$ debdiff /var/cache/pbuilder/sid/result/hobbit-plugins_2014{1006,1201}.dsc
diff -Nru hobbit-plugins-20141006/client-ext/apt hobbit-plugins-20141201/client-ext/apt
--- hobbit-plugins-20141006/client-ext/apt      2014-05-23 03:31:28.000000000 +0200
+++ hobbit-plugins-20141201/client-ext/apt      2014-11-28 16:43:40.000000000 +0100
@@ -202,7 +202,7 @@
     $inst = $1 if / +Installed: (.+)/;
     $cand = $1 if / +Candidate: (.+)/;
     $pin = $1 if / +Package pin: (.+)/ and $1 eq $inst;
-    if (/^[ *]+(\S+) (\d+)$/) {
+    if (/^ (?:   |\*\*\*) (\S*[^\s:]) (\d+)$/) {
         $in_dist = ($1 eq $cand);
         $pinprio = $2;
     }
diff -Nru hobbit-plugins-20141006/debian/changelog hobbit-plugins-20141201/debian/changelog
--- hobbit-plugins-20141006/debian/changelog    2014-10-06 14:50:47.000000000 +0200
+++ hobbit-plugins-20141201/debian/changelog    2014-12-01 12:33:05.000000000 +0100
@@ -1,3 +1,10 @@
+hobbit-plugins (20141201) unstable; urgency=medium
+
+  * Fix parsing of "apt-cache policy" output in cases where the version of
+    the first listed package only contains digits. (Closes: #770467)
+
+ -- Axel Beckert <abe@debian.org>  Mon, 01 Dec 2014 12:33:05 +0100
+
 hobbit-plugins (20141006) unstable; urgency=medium
 
   * mount-ro: Do not alert about read-only tmpfs mounts (Closes: #764197)

While the changelog entry may suggest that bug only surfaced under the
mentioned conditions, it could also lead to false negatives in other
cases. But the exact conditions for that are unknown. (It caused false
positives under the mentioned conditions. Which is how it got noticed.)

Changes debdiff:

$ debdiff /var/cache/pbuilder/sid/result/hobbit-plugins_2014{1006,1201}_amd64.changes
File lists identical (after any substitutions)

Control files: lines which differ (wdiff format)
------------------------------------------------
Installed-Size: [-290-] {+291+}
Version: [-20141006-] {+20141201+}

So please unblock hobbit-plugins/20141201

-- System Information:
Debian Release: 8.0
  APT prefers unstable
  APT policy: (990, 'unstable'), (600, 'testing'), (500, 'buildd-unstable'), (400, 'stable'), (110, 'experimental'), (1, 'buildd-experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.17-rc5-amd64 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash


Reply to: