Bug#702109: unblock: crystalhd/1:0.0~git20110715.fdd2f19-8
retitle 702109 unblock: crystalhd/1:0.0~git20110715.fdd2f19-9
stop
On Saturday, March 02, 2013 2:43:26 PM Adam D. Barratt wrote:
> As per our last d-d-a mail in January[1], release goal changes no longer
> qualify for unblocks.
>
> Regards,
>
> Adam
>
> [1] http://lists.debian.org/debian-devel-announce/2013/01/msg00005.html
Ok, please unblock crystalhd/1:0.0~git20110715.fdd2f19-9.
This will only have the removal of the dkms package to
address bugs 682252 and 699470. Note the bug 682252
was marked a normal bug, but both were actually the
same bug and both were release critical.
Here is the debdiff from the current package in testing
to the new package in unstable.
diff -Nru crystalhd-0.0~git20110715.fdd2f19/debian/changelog crystalhd-0.0~git20110715.fdd2f19/debian/changelog
--- crystalhd-0.0~git20110715.fdd2f19/debian/changelog 2013-03-02 14:23:07.000000000 -0500
+++ crystalhd-0.0~git20110715.fdd2f19/debian/changelog 2013-03-02 17:45:53.000000000 -0500
@@ -1,3 +1,23 @@
+crystalhd (1:0.0~git20110715.fdd2f19-9) unstable; urgency=high
+
+ * New package upload with just fixes to remove dkms package.
+ * Revert bump to Standards-Version 3.9.4.
+ * Revert build with hardening options to satisfy Wheezy release goal.
+
+ -- Andres Mejia <amejia@debian.org> Sat, 02 Mar 2013 17:43:59 -0500
+
+crystalhd (1:0.0~git20110715.fdd2f19-8) unstable; urgency=high
+
+ * Remove dkms package which contained buggy driver.
+ Driver already existed in mainline kernel. Any issues with the driver
+ should be directed to the kernel package.
+ (Closes: #682252)
+ (Closes: #699470)
+ * Bump to Standards-Version 3.9.4.
+ * Build with hardening options to satisfy Wheezy release goal.
+
+ -- Andres Mejia <amejia@debian.org> Sat, 02 Mar 2013 13:34:36 -0500
+
crystalhd (1:0.0~git20110715.fdd2f19-7) unstable; urgency=low
* Include udev rules for crystalhd-dkms.
diff -Nru crystalhd-0.0~git20110715.fdd2f19/debian/control crystalhd-0.0~git20110715.fdd2f19/debian/control
--- crystalhd-0.0~git20110715.fdd2f19/debian/control 2013-03-02 14:23:07.000000000 -0500
+++ crystalhd-0.0~git20110715.fdd2f19/debian/control 2013-03-02 17:43:19.000000000 -0500
@@ -3,8 +3,7 @@
Maintainer: Andres Mejia <amejia@debian.org>
Build-Depends: debhelper (>= 8.1.3~),
libgstreamer0.10-dev,
- libgstreamer-plugins-base0.10-dev,
- dkms
+ libgstreamer-plugins-base0.10-dev
Standards-Version: 3.9.3
Section: libs
Homepage: http://www.broadcom.com/support/crystal_hd/
@@ -37,18 +36,6 @@
.
This package contains the shared library.
-Package: crystalhd-dkms
-Section: kernel
-Architecture: amd64 i386
-Depends: ${shlibs:Depends}, ${misc:Depends}, dkms
-Suggests: linux-headers
-Description: Crystal HD Video Decoder (Linux kernel driver)
- Crystal HD Solution is a product offered by Broadcom. It is used to enable
- flawless playback of 1080p high definition video across a wide range of
- systems.
- .
- This package contains the crystalhd Linux kernel driver.
-
Package: gstreamer0.10-crystalhd
Section: video
Architecture: amd64 i386
diff -Nru crystalhd-0.0~git20110715.fdd2f19/debian/crystalhd-dkms.dkms crystalhd-0.0~git20110715.fdd2f19/debian/crystalhd-
dkms.dkms
--- crystalhd-0.0~git20110715.fdd2f19/debian/crystalhd-dkms.dkms 2013-03-02 14:23:07.000000000 -0500
+++ crystalhd-0.0~git20110715.fdd2f19/debian/crystalhd-dkms.dkms 1969-12-31 19:00:00.000000000 -0500
@@ -1,11 +0,0 @@
-# DKMS configuration for crystalhd
-
-PACKAGE_NAME="crystalhd"
-PACKAGE_VERSION="#MODULE_VERSION#"
-BUILT_MODULE_NAME[0]="$PACKAGE_NAME"
-BUILT_MODULE_LOCATION[0]=driver/linux
-DEST_MODULE_LOCATION[0]="/updates/dkms/"
-AUTOINSTALL=yes
-
-MAKE[0]="cd driver/linux && ./configure && make"
-CLEAN="make -C driver/linux clean distclean"
diff -Nru crystalhd-0.0~git20110715.fdd2f19/debian/crystalhd-dkms.install crystalhd-0.0~git20110715.fdd2f19/debian/crystalhd-
dkms.install
--- crystalhd-0.0~git20110715.fdd2f19/debian/crystalhd-dkms.install 2013-03-02 14:23:07.000000000 -0500
+++ crystalhd-0.0~git20110715.fdd2f19/debian/crystalhd-dkms.install 1969-12-31 19:00:00.000000000 -0500
@@ -1,2 +0,0 @@
-usr/src
-lib/udev/rules.d
diff -Nru crystalhd-0.0~git20110715.fdd2f19/debian/rules crystalhd-0.0~git20110715.fdd2f19/debian/rules
--- crystalhd-0.0~git20110715.fdd2f19/debian/rules 2013-03-02 14:23:07.000000000 -0500
+++ crystalhd-0.0~git20110715.fdd2f19/debian/rules 2013-03-02 17:43:52.000000000 -0500
@@ -1,8 +1,5 @@
#!/usr/bin/make -f
-UPSTREAM_VERSION = $(shell dpkg-parsechangelog | grep -G '^Version' | \
- cut -d ' ' -f 2 | sed 's/^[^:]:*//' | sed 's/-.*$$//')
-
DEB_HOST_MULTIARCH ?= $(shell dpkg-architecture -qDEB_HOST_MULTIARCH)
EXTRA_INCLUDES = -I$(CURDIR)/include \
@@ -11,7 +8,7 @@
EXTRA_LD_PATH = -L$(CURDIR)/linux_lib/libcrystalhd
%:
- dh $@ --with dkms
+ dh $@
override_dh_auto_build:
make -C linux_lib/libcrystalhd
@@ -24,18 +21,9 @@
make install -C linux_lib/libcrystalhd DESTDIR=$(CURDIR)/debian/tmp \
LIBDIR=/usr/lib/$(DEB_HOST_MULTIARCH)
make install -C filters/gst/gst-plugin DESTDIR=$(CURDIR)/debian/tmp
- mkdir -p $(CURDIR)/debian/tmp/usr/src/crystalhd-$(UPSTREAM_VERSION)
- cp -rf driver $(CURDIR)/debian/tmp/usr/src/crystalhd-$(UPSTREAM_VERSION)
- cp -rf include $(CURDIR)/debian/tmp/usr/src/crystalhd-$(UPSTREAM_VERSION)
- rm -f $(CURDIR)/debian/tmp/usr/src/crystalhd-$(UPSTREAM_VERSION)/driver/linux/bcm_70012_dev.sh
- rm -f $(CURDIR)/debian/tmp/usr/src/crystalhd-$(UPSTREAM_VERSION)/driver/linux/bcm_70012_run.sh
- install -D -m 0644 driver/linux/20-crystalhd.rules $(CURDIR)/debian/tmp/lib/udev/rules.d/20-crystalhd.rules
override_dh_auto_clean:
dh_clean
make clean -C linux_lib/libcrystalhd
[ ! -f filters/gst/gst-plugin/Makefile ] || \
make clean distclean -C filters/gst/gst-plugin
-
-override_dh_dkms:
- dh_dkms -V $(UPSTREAM_VERSION)
--
Andres
Reply to: