Re: Test failure in Rdpack
Hi Georgi,
thanks for your quick reply.
On Sun, Aug 29, 2021 at 10:22:36AM +0000, Georgi Boshnakov wrote:
> Hi Andreas,
>
> I found your github repo and figured out what is wrong. The test error occurs with rbibutils versions < 2.1.1 (it seems to be 2.0 in your setting).
Ahhh, I admit I have realised that rbibutils is not up to date - I'm on it
to update this. For sure we intend to update everything now since Debian
freeze is over. I think to be safe on Rdpack it makes sense to use a
versioned Depends which had pointed me to the issue immediately.
> It can be fixed by replacing line 5 in tests/testthat/test-bib.R (the one throwing the error) with
>
> bibs_rb <- if(packageVersion("rbibutils") >= '2.1.1')
> readBib(fn_rb) else readBib(fn_rb, encoding = "UTF-8")
>
> I have updated this on my github repo at https://github.com/GeoBosh/Rdpack .
>
> Alternatively, if you intend to update package rbibutils, the error in Rdpack will disappear.
Yup. This will happen soon.
> Thanks for maintaining the debian repositories.
You are welcome.
Kind regards
Andreas.
> Kind regards,
> Georgi
>
> =================
> From: Georgi Boshnakov
> Sent: 29 August 2021 09:35
> To: Andreas Tille <andreas@an3as.eu>; Debian R <debian-r@lists.debian.org>
> Subject: RE: Test failure in Rdpack
>
>
> Hi Andreas,
>
> Sorry for the previous email, accidently send it prematurely from my mobile.
>
> Thanks for the report. This may be difficult for me to debug, as it passes the CRAN checks on Debian. I have also just checked it on debian with various compilers using rhub::check() with no errors.
>
> Any chance of passing the session information - in a fresh R session:
>
> library("Rdpack")
> sessionInfo()
>
> Thanks,
> Georgi
>
>
> From: Georgi Boshnakov <mailto:georgi.boshnakov@manchester.ac.uk>
> Sent: 29 August 2021 09:24
> To: Andreas Tille <mailto:andreas@an3as.eu>; Debian R <mailto:debian-r@lists.debian.org>
> Subject: Re: Test failure in Rdpack
>
> Hi Andreas,
>
> Thanks for the report. Any chance of passing
>
> Get https://aka.ms/AAb9ysg
> ________________________________________
> From: Andreas Tille <mailto:andreas@an3as.eu>
> Sent: Sunday, August 29, 2021 6:14:25 AM
> To: Georgi Boshnakov <mailto:georgi.boshnakov@manchester.ac.uk>; Debian R <mailto:debian-r@lists.debian.org>
> Subject: Test failure in Rdpack
>
> Hi Georgi,
>
> I tried to update Georgi in Debian to version 2.1.2. Unfortunately I get
> a test suite error:
>
> ══ Failed tests ════════════════════════════════════════════════════════════════
> ── Error (test-bib.R:5:5): bib works fine ──────────────────────────────────────
> Error: argument "encoding" is missing, with no default
> Backtrace:
> █
> 1. └─rbibutils::readBib(fn_rb) test-bib.R:5:4
>
> Could you please have a look.
>
> Kind regards
>
> Andreas.
>
> --
> http://fam-tille.de
>
>
--
http://fam-tille.de
Reply to: