[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1059631: marked as done (qhelpgenerator-qt5: nearly-reproducible LastRegisterTime value in .qch files is not timezone-normalized)

Your message dated Sat, 13 Jan 2024 20:35:02 +0000
with message-id <E1rOkic-00EXDM-Fy@fasolo.debian.org>
and subject line Bug#1059631: fixed in qttools-opensource-src 5.15.12-2
has caused the Debian Bug report #1059631,
regarding qhelpgenerator-qt5: nearly-reproducible LastRegisterTime value in .qch files is not timezone-normalized
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1059631: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1059631
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: qhelpgenerator-qt5
Version: 5.15.2-3
Severity: wishlist
User: reproducible-builds@lists.alioth.debian.org
Usertags: timezone
X-Debbugs-Cc: reproducible-bugs@lists.alioth.debian.org

Dear Maintainer,

Looking at some recent Reproducible Build[1] test results[2] for the Debian
openorienteering-mapper package, the LastRegisterTime value placed into the
SettingsTable table in the .qch (sqlite3 db) file format can vary based on
the build host's configuration.

Inspecting the patch from #875847 and the values that appear in the diffoscope
output from the build logs: the SOURCE_DATE_EPOCH value of the build is used,
as expected, to improve the reproducibility of the build.  It takes the value
of the most recent Debian changelog entry.

However: the patch mutates an existing QT QDateTime instance (last_modified) to
store the seconds-since-epoch value -- without specifying a timezone for the
value.

I'm not 100% certain, but I think it's likely (given that the duration
between the two timestamps that appear in the diffoscope output is 26 hours,
equal to the local-time-difference between GMT-14 and GMT+12, the two build
timezones) that the last_modified object remains timezone-relative in each
build, and therefore emits differing LastRegisterTime values in ISO format.

  -INSERT INTO SettingsTable VALUES('LastRegisterTime','2021-12-27T21:45:41.000');
  +INSERT INTO SettingsTable VALUES('LastRegisterTime','2021-12-28T23:45:41.000');

My sense is that the LastRegisterTime column value is probably intended to be
stored in UTC; it may be sufficient to set the timezone of the last_modified
instance to UTC -- making careful to ensure that it is indeed a _set_ timezone
operation and not a _translate_ timezone operation.

Regards,
James

[1] - https://reproducible-builds.org/

[2] - https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/arm64/diffoscope-results/openorienteering-mapper.html

[3] - https://doc.qt.io/qt-5/qdatetime.html

--- End Message ---
--- Begin Message --- 
Source: qttools-opensource-src
Source-Version: 5.15.12-2
Done: Dmitry Shachnev <mitya57@debian.org>

We believe that the bug you reported is fixed in the latest version of
qttools-opensource-src, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1059631@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Dmitry Shachnev <mitya57@debian.org> (supplier of updated qttools-opensource-src package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sat, 13 Jan 2024 22:58:29 +0300
Source: qttools-opensource-src
Architecture: source
Version: 5.15.12-2
Distribution: experimental
Urgency: medium
Maintainer: Debian Qt/KDE Maintainers <debian-qt-kde@lists.debian.org>
Changed-By: Dmitry Shachnev <mitya57@debian.org>
Closes: 1059592 1059631
Changes:
 qttools-opensource-src (5.15.12-2) experimental; urgency=medium
 .
   * Backport upstream patch to ensure FileAttributeSetTable is filled
     ordered (closes: #1059592).
   * Backport upstream patch to localize SOURCE_DATE_EPOCH to UTC in
     qhelpgenerator (closes: #1059631).
   * Update debian/libqt5designer5.symbols for hurd-i386.
Checksums-Sha1:
 3fcb744d4eff160ae28207ac4a29d3621c2e304c 4065 qttools-opensource-src_5.15.12-2.dsc
 12f123793b7f6b0778ff5e13beb3405a86c8dd6f 49708 qttools-opensource-src_5.15.12-2.debian.tar.xz
 f3e84dcb1610d78d52d393012ff8fd9158f8c94f 13471 qttools-opensource-src_5.15.12-2_source.buildinfo
Checksums-Sha256:
 a664c8d5a16ce4c0879394114ea667e45df4b8aeecd40690712b38fca7782e2f 4065 qttools-opensource-src_5.15.12-2.dsc
 32e0db5086897dfd388b8a72952699a21a6484f15d6905fbd80993ef75eadcff 49708 qttools-opensource-src_5.15.12-2.debian.tar.xz
 58971dabe7b3de52bdd33f9159cfb68d8a5b5821adf68aeb11743448b5f10b68 13471 qttools-opensource-src_5.15.12-2_source.buildinfo
Files:
 7dc63ed04611ceec949016190c0b3f8b 4065 libs optional qttools-opensource-src_5.15.12-2.dsc
 7cffbab06f8c1e5adacb6420c2917cf8 49708 libs optional qttools-opensource-src_5.15.12-2.debian.tar.xz
 575f74fea4abd5e6c54a0b768e1d94b3 13471 libs optional qttools-opensource-src_5.15.12-2_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQJHBAEBCgAxFiEEq2sdvrA0LydXHe1qsmYUtFL0RrYFAmWi6+ETHG1pdHlhNTdA
ZGViaWFuLm9yZwAKCRCyZhS0UvRGtlLmD/9ivWYoJiQC1qL2ISgHwd2pesED+Dt+
kDdrPeEsTTAbpQ4cbmdt3mYldLvEp9wtfcUpQ1KL6l5+0cIgl00tgpKvx0TyQUbq
2Tz/z6icol+XEqPyWPz9/PELyDcP3oqegkK5nibGokbf53DtvR2Z0yB+YYRZhchg
s7MEEYBLdOM+x+/Fqz85ttipRz2ER9T75fMIB2WbpyCe8LRgwZRDNmpypTLT6f7B
QIGSZM08ie5MwkzyQHsE3XtzpK0B43NVsIge3FbdU4anQWc67q3il0S32lu18kMu
ujyI1pTHgOlwEuSx88jc5hogfEb6LnQHyxjTnmboby0dqhsisvfw3TX6aWTG3Ti4
rLli34hi6OPb9teUSlqtjNEldmhvv1P1Onwcqtdh8P3BR96tnP/+xLfeXRI6VzuR
gRNYFYgUwuhFbyJBLjuGKU6SA35PsUe1713JekfvlbfwcW1Jt97uOhOysFsXaDM/
BiDsMSylnGIbnYh3wcHi6DM+Oexc6jehgpWf+KFaZLZnIcw1yc5ltbvgWEz6Sd5H
jFLVebOSPMc9OEkTObVzCsc4gOddQWAA1m1QPDgT5BE2MXscxCW8n8mflQLu4xwY
rKe2n2eYmiTiapC5ezl/12oaLn9oA6dw1JH57m/UGd29tZmEIIsrbaxmfm9sn9qH
fZEREDFr7+XsiQ==
=tsA3
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: