Re: Bug#373218: qa.debian.org: Patch
On Thu, 28 Jun 2007, Russ Allbery wrote:
> > --- orig/html_reports 2007-06-28 12:33:42.000000000 -0500
> > +++ new/html_reports 2007-06-28 12:14:58.000000000 -0500
> > @@ -480,11 +480,7 @@
>
> > my $file = $maint;
> > if ($file) {
> > - $file =~ s/^(.+)\<.*$/$1/;
> > - $file =~ tr/A-Za-z0-9_.,/_/c;
> > - $file =~ s/^_+//g;
> > - $file =~ s/_+$//g;
> > -
> > + $file =~ s/^[^<]+\<([^>]+)$/$1/;
> > $file = "m$file.html";
> > } else {
> > $file = "munsorted.html";
>
> You can't drop that tr///. It's what takes care of all the special
> characters that otherwise need escaping.
Since he extracts the email part, it's less of a problem.
> Why not just fix the qa code to match what lintian does? It's pretty
> clearly currently different, which is probably the root of the problem.
There's no tr///c in XSLT ... it's difficult for me to generate the
proper link to the lintian page because of this.
Thus I agree (in principle, not necessarily with this patch) with changing
the naming of the lintian pages.
Cheers,
--
Raphaël Hertzog
Premier livre français sur Debian GNU/Linux :
http://www.ouaza.com/livre/admin-debian/
Reply to: