[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#901335: marked as done (id3ren is stripped during make install)

Your message dated Wed, 15 Dec 2021 15:04:05 +0000
with message-id <E1mxVp7-000JA5-7Q@fasolo.debian.org>
and subject line Bug#901335: fixed in id3ren 1.1b0-8
has caused the Debian Bug report #901335,
regarding id3ren is stripped during make install
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
901335: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=901335
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Source: id3ren
Version: 1.1b0-7
Tags: patch
User: helmutg@debian.org
Usertags: rebootstrap

make install strips id3ren. This breaks:
 * Handling of DEB_BUILD_OPTIONS=nostrip -> #437191
 * Generation of a -dbgsym package
 * Cross building (as the build architecture strip is used)

Please consider applying the attached patch or bumping the debhelper
compatibility level to at least 11. Doing so also fixes #437191.

Helmut

diff --minimal -Nru id3ren-1.1b0/debian/changelog id3ren-1.1b0/debian/changelog
--- id3ren-1.1b0/debian/changelog	2016-06-05 07:38:41.000000000 +0200
+++ id3ren-1.1b0/debian/changelog	2018-06-11 17:37:17.000000000 +0200
@@ -1,3 +1,10 @@
+id3ren (1.1b0-7.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Don't strip during make install. (Closes: #-1)
+
+ -- Helmut Grohne <helmut@subdivi.de>  Mon, 11 Jun 2018 17:37:17 +0200
+
 id3ren (1.1b0-7) unstable; urgency=low
 
   * QA upload.
diff --minimal -Nru id3ren-1.1b0/debian/rules id3ren-1.1b0/debian/rules
--- id3ren-1.1b0/debian/rules	2016-06-05 01:45:20.000000000 +0200
+++ id3ren-1.1b0/debian/rules	2018-06-11 17:37:15.000000000 +0200
@@ -5,3 +5,6 @@
 
 %:
 	dh  $@
+
+override_dh_auto_install:
+	dh_auto_install -- INSTALL='install --strip-program=true'

--- End Message ---
--- Begin Message --- 
Source: id3ren
Source-Version: 1.1b0-8
Done: David da Silva Polverari <david.polverari@gmail.com>

We believe that the bug you reported is fixed in the latest version of
id3ren, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 901335@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
David da Silva Polverari <david.polverari@gmail.com> (supplier of updated id3ren package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 15 Dec 2021 03:24:22 +0000
Source: id3ren
Architecture: source
Version: 1.1b0-8
Distribution: unstable
Urgency: medium
Maintainer: Debian QA Group <packages@qa.debian.org>
Changed-By: David da Silva Polverari <david.polverari@gmail.com>
Closes: 437191 901335
Changes:
 id3ren (1.1b0-8) unstable; urgency=medium
 .
   * QA upload.
   * Using new DH level format. Consequently:
       - debian/compat: removed.
       - debian/control: changed from 'debhelper' to 'debhelper-compat' in
         Build-Depends field and bumped level to 13.
   * debian/control:
       - Added 'Rules-Requires-Root: no' to source stanza.
       - Added the Vcs-* fields.
       - Bumped Standards-Version to 4.6.0.
   * debian/copyright:
       - Fixed upstream and packaging license.
       - Updated packaging copyright data.
       - Updated upstream copyright years.
       - Using a secure copyright format URI.
   * debian/id3ren.1: created to fix spelling and groff errors from the upstream
     manpage, as the latter was provided only in the gzip format.
   * debian/id3ren.manpages: modified to install the fixed manpage instead of the
     upstream one.
   * debian/patches/:
       - 01_install.patch: modified to improve hardening and avoid stripping the
         binary during the build. (Closes: #437191, #901335)
       - 05_spelling.patch: created to fix the spelling of an ID3 music genre.
       - Decremented the numbering of patches 04_genre.patch and
         05_directory.patch to make up for the removal of 03_manpage.patch on the
         previous packaging revision.
       - Updated all headers and fixed author information lost because of the
         conversion from 1.0 to 3.0 (quilt).
   * debian/rules: exported DEB_BUILD_MAINT_OPTIONS variable to improve
     hardening.
   * debian/salsa-ci.yml: added to provide CI tests for Salsa.
   * debian/source/:
       - include-binaries: created to allow the inclusion of the minimal MP3 file
         meant for CI testing.
       - lintian-overrides: created to explain about the inclusion of the fixed
         manpage.
   * debian/tests/:
       - control: created to coordinate and perform CI tests for the installed
         package.
       - minimal.mp3: created as a minimal MP3 file containing metadata meant for
         package testing.
       - rename: created to exercise basic package functionality.
   * debian/watch: created to check for updates on a placeholder URL to clarify
     that the original upstream homepage is missing.
Checksums-Sha1:
 9a9aec9b56096af34fdf92afe5be7b06a376044a 1833 id3ren_1.1b0-8.dsc
 5f733c4ea5c622f9ac293d4f30d9d70989a7bd28 8036 id3ren_1.1b0-8.debian.tar.xz
 fc3dba87757d47d61f9e16b92aef0c5f61f1ea58 5448 id3ren_1.1b0-8_source.buildinfo
Checksums-Sha256:
 afef98baecda2e55f38da24ed78c3dce8cc2192f4a5703cb05ce37b176925cd7 1833 id3ren_1.1b0-8.dsc
 a7ec77393448c03d6f1fe37788fe23820f95c990df0e5b415ebf88c2be2be2d3 8036 id3ren_1.1b0-8.debian.tar.xz
 b64cb0868574f41398af2f637f6cc15431ddb161a3f1688a690ae9cc4f4821a3 5448 id3ren_1.1b0-8_source.buildinfo
Files:
 8768b59ee71bb49ea4ea4dd756cef0ff 1833 sound optional id3ren_1.1b0-8.dsc
 30c009d95d8e7d9336e236eb58e64c74 8036 sound optional id3ren_1.1b0-8.debian.tar.xz
 f40ab1efc9294abd4dde458eb9383d99 5448 sound optional id3ren_1.1b0-8_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEENX3LDuyVoBrrofDS3mO5xwTr6e8FAmG6AUQACgkQ3mO5xwTr
6e/JPw//UCnBtucOsWryfQ2FH3cOUDD+yLv7jmpiqO50dwh4IgKKzwwC7FfH501a
MgoUngZpDQ+vZxxLfdZ3NNPlvoULtIUlcajwNTtkNar7U6p1NR/+bnKwR2yp3HXs
igsHaSC0gqwWKMPFzXMpzGkPgUL6YQMm9GGLRgQGE6x0uqbwDX5x0s6WglxlhmSx
T3sdLvXK0xh+uG31rv/uAr8+Xa1Y9yvKuTjuy7kPyRf6srspA8V2Xt/Xq5qVPc6T
69LF3q7cXPmdj64ANUyBAwXorID7F71RRvKzCPsqyq1oOnzzecBe7coi4gn6AZao
4KEKhcO10Q1YrPzUV61LF4uE1ce2gClj5/uS0uwUFxZdG65e6FabiHW/YMmm8yRI
rp7LzWhUGGeb3DfjfYk7uIvDyMxkjEjoKIoPG5TiZFzRHMt9WOnF4AlwvEK0fexZ
cx9/XktmAC2dCUq9NgFlcRFTuFZBJox+O/54sSHcmrVWLH90mHqbBj7EXlTSG1Sg
7aZdWiDeBuFAA9GAd5ypyICzabhxHgw+19c9ZBrjOVroEJtr9BBQg6d9FTjC2W80
5mBRD9xoPrt0ZkTZ934D219N7pKZURSQkwc2/5dv43TealJJUeWkyLm3X8T6YZx+
+rhYaLqn7Qm9yvtZDsdc8yhiHkLxgWiQDIMlIjqXsdeI+MUR88M=
=bXuO
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: